[ADD] Add option for Odoo 17.0 #425

celm1990 · 2023-11-11T06:31:52Z

I'm not sure if it's a good idea to use Copier 9, but I have problems with the old version. @yajo, can you please review?

TODO: adapt github actions to V17 and PY 3.10

Is need execute copier copy with option --trust similar to OCA/oca-addons-repo-template#202

copier.yml

- copier: user sintax according seven point of https://copier.readthedocs.io/en/v9.0.1/changelog/#v800-2023-06-04 copier SUBCOMMAND args instead of copier args SUBCOMMAND

celm1990 · 2023-11-12T06:31:34Z

@pedrobaeza @yajo

Please review the comments associated with each commit for additional details.

I attempted to adapt the test, but encountered errors during precommit. I suspect this is because the oca-addons-repo-template now utilizes ruff instead of black, isort, flake8, autoflake, and pyupgrade. However, I am uncertain whether the maximum line length is now set to 79 instead of 88. @sbidoul, could you please provide your insights on this matter?

Refer to the following commit for the changes: OCA/oca-addons-repo-template@49b350f

pedrobaeza · 2023-11-12T12:00:21Z

Better to do this in several steps: limit this PR to enable the 17.0 version, and then we can investigate about switching to ruff in another one. Check anyway the file https://github.com/OCA/oca-addons-repo-template/blob/master/src/%7B%25%20if%20use_ruff%20%25%7D.ruff.toml%7B%25%20endif%25%7D.jinja for ruff options.

celm1990 · 2023-11-12T15:44:21Z

Better to do this in several steps: limit this PR to enable the 17.0 version, and then we can investigate about switching to ruff in another one.

Currently, the process is not functional without some adjustments. This is necessary due to changes made in the oca-addons-repo-template repository first on this commit the files .flake8 .isort.cfg were removed. Following that, in
this commit an option for version 17 was recently added. As a result, it's imperative to adapt to these changes.

For visual reference, please find the screenshot below:

celm1990 · 2023-11-13T02:27:45Z

@pedrobaeza I updated code for flake8 and isort, before the file content are taken from oca-addons-repo-template but on this PR are delete this files OCA/oca-addons-repo-template#219 So now I put content directly here. Can you enable github actions and review please

yajo · 2023-11-13T07:47:43Z

tests/samples/mqt-diffs/v10.0-.pylintrc-mandatory.diff

thought: these diff files are less helpful each time. The origin idea behind these files was to implement some kind of snapshot testing that served us as a warning sign when we diverged from the recommended linter configurations from OCA.

However, it's impossible for a human to interpret correctly 16 plain diffs in a review.

Back then, when oca-addons-repo-template didn't exist, OCA was using standard configurations per version, based on their MQT repo, which is mostly useless today (OCA/maintainer-quality-tools#717).

Now that updates are based on Copier, and don't happen randomly, what's the point on freezing the linter configurations per version? It's useless IMHO. Linters don't happen at Odoo runtime. They happen at dev time, in the dev laptop. Or on CI, in separate jobs. You can lint today code for Odoo 8 using today's linters, with a modern python version, and it will lint it properly.

So linters should depend on the template version, and not on the odoo version. In OCA they don't think like this and it's a maintenance burden in their template. I don't think we should follow the same path.

IMHO we should just review the new linters, enable those that make sense for all supported versions, and remove this diff snapshotting method.

Hi, this is my first contribution into doodba-copier-template and I attempted to adhere to this guide. However, upon executing invoke update-test-samples all diff are altered, I'm having difficulty understanding why it has become more complex.
Do you recommend removing all the test related?

Currently, my primary objective is to enable V17 for Doodba. Unfortunately, the testing process is proving to be intricate and a bit frustrating. :(

Let's remove the diff tests all together then.

I removed all test related, can you enable github actions please .
On my repo get the followin error(The test attempts to commit with a manifest containing a higher version, and it should fail the pre-commit check) , but Pylint-odoo working properly up to version v8.0.5, but starting from version v8.0.6, it encounters issues., please check issue reported here

AFAIK, the names of the linters to execute changed on that version from underscores (_) to dashes (-).

AFAIK, the names of the linters to execute changed on that version from underscores (_) to dashes (-).

The configuration is OK, issue become from pylint-odoo not support V17.0 yet.
waiting OCA/pylint-odoo#477 to upgrade oca-addons-repo-template and try again

see more details on Tecnativa#425 (comment)

celm1990 · 2023-11-17T18:29:46Z

@pedrobaeza @yajo
I updated code, could please enable github actions, on my repo test are execute and green
https://github.com/celm1990/doodba-copier-template/actions/runs/6907131396

celm1990 · 2023-11-18T04:21:10Z

@pedrobaeza @yajo
Can you please help me, I run test on my repo but for V14.0 the tests never finished
When I removed version 14.0 from the CI, now all the tests are completing successfully. I don't understand why

For version 14.0 I couldn't find relevant information in the logs(I added the --verbose flag)
https://github.com/celm1990/doodba-copier-template/actions/runs/6911268511/job/18805570859

celm1990 · 2023-11-18T21:45:04Z

@pedrobaeza @yajo
Help me please, I tried understand test on doodba-copier-template, in this test is used doodba-qa to test pylint However, as mentioned in another issue, pylint-odoo after version v8.0.6 is need replace underscore by dashes, Therefore, is it necessary to adapt doodba-qa as well, or are these tests obsolete?
Please refer to:
https://github.com/Tecnativa/doodba-qa/blob/fcd49526d9a8deed03d5584912f37e3626d7fba9/insider/pylint#L30

I hope I explained myself well.

see more details on Tecnativa#425 (comment)

yajo · 2023-11-20T10:09:39Z

IIRC doodba-qa should be archived, as it is no longer used.

celm1990 · 2023-11-20T14:33:26Z

@yajo @pedrobaeza
I commented on a test related to backup because, for some reason, this test for v14.0 never finishes. Could you enable CI? Additionally, can you review this test if something is causing an issue? I've checked everything and it all seems normal, but I don't understand.

On my repo all test are gree(but without this commit)
https://github.com/celm1990/doodba-copier-template/actions/runs/6917156814

celm1990 · 2023-11-20T16:15:18Z

@yajo @pedrobaeza all tests are OK, CI is green without this commit, but if these tests are enabled, V14.0 never finishes. I haven't changed the code in this test; everything seems normal, but I don't understand. Any ideas?

Please your help

pedrobaeza · 2023-11-20T18:05:31Z

@celm1990 Please remove the last 2 commits and instead, just add one commenting the import of the test in __init__.py. We merge this for having the scaffolding available, and later we investigate about the failure.

celm1990 · 2023-11-20T19:12:17Z

@celm1990 Please remove the last 2 commits and instead, just add one commenting the import of the test in __init__.py. We merge this for having the scaffolding available, and later we investigate about the failure.

@pedrobaeza I see __init__.py and it's empty, where is done import?

pedrobaeza · 2023-11-20T19:27:59Z

OK, try to rename the file instead. It seems it imports all the files starting with test_.

pedrobaeza · 2023-11-21T07:43:30Z

.flake8.jinja

@@ -1 +1,10 @@
-{%- include "vendor/oca-addons-repo-template/.flake8" -%}
+[flake8]


I see that you have hardcoded this. The idea is to use the same linter configuration here that on oca-addons-repo-template, so instead you have to use the new .pre-commit-config.yaml from vendor submodule and remove these ones.

if you replace for ruff, probably this file will not be needed anymore.

Yes, that's the idea. In fact, the .pre-commit-config.yaml from oca-addons-repo-template has changed to ruff (not the one being templated):

https://github.com/OCA/oca-addons-repo-template/blob/8ad97a63fde3efe033fb262a6fb73d08a897e73d/.pre-commit-config.yaml#L24

.pre-commit-config.yaml.jinja

inspired by OCA/oca-addons-repo-template@1e6e78b

see more details on Tecnativa#425 (comment)

- odoo to V17 change module note and add project_todo, this commit adapt test

this test never finished by an unknown reason(for V14.0)

inspired by OCA/oca-addons-repo-template@299cb36 - remove flake8, isort

Versions from V7 to V10 are skipped in the test, so they should be removed from the CI.

celm1990 · 2023-11-23T14:28:03Z

@pedrobaeza
I squashed the commits and removed V7-10 from CI. Please let me know if any additional changes are needed or if this PR is ready to merge?.

pedrobaeza

Thanks for the effort.

pedrobaeza reviewed Nov 11, 2023

View reviewed changes

copier.yml Show resolved Hide resolved

celm1990 force-pushed the main-V17 branch from 69cd20f to a505926 Compare November 11, 2023 15:54

celm1990 requested a review from pedrobaeza November 11, 2023 15:55

celm1990 added 2 commits November 12, 2023 00:45

[UPD] Update oca-addons-repo-template to latest branch v1.18

b3169e6

[IMP] add option for Odoo 17.0

eba77e4

- copier: user sintax according seven point of https://copier.readthedocs.io/en/v9.0.1/changelog/#v800-2023-06-04 copier SUBCOMMAND args instead of copier args SUBCOMMAND

celm1990 force-pushed the main-V17 branch from a505926 to 6754df5 Compare November 12, 2023 06:21

celm1990 marked this pull request as ready for review November 12, 2023 06:23

celm1990 mentioned this pull request Nov 12, 2023

Enable ruff line too long check OCA/oca-addons-repo-template#231

Merged

celm1990 force-pushed the main-V17 branch from 6754df5 to 7298b72 Compare November 13, 2023 02:22

yajo reviewed Nov 13, 2023

View reviewed changes

celm1990 added a commit to celm1990/doodba-copier-template that referenced this pull request Nov 14, 2023

[REM] remove old system testing of linters

5d858f0

see more details on Tecnativa#425 (comment)

celm1990 mentioned this pull request Nov 17, 2023

[IMP] add support to Odoo v17.0 OCA/pylint-odoo#477

Merged

celm1990 mentioned this pull request Nov 18, 2023

[ADD] Add 17.0 scaffolding #429

Closed

celm1990 added a commit to celm1990/doodba-copier-template that referenced this pull request Nov 19, 2023

[REM] remove old system testing of linters

8eef694

see more details on Tecnativa#425 (comment)

celm1990 force-pushed the main-V17 branch from c3a66e2 to 8966298 Compare November 19, 2023 00:24

pedrobaeza changed the title ~~[WIP] Add option for Odoo 17.0~~ [ADD] Add option for Odoo 17.0 Nov 20, 2023

celm1990 force-pushed the main-V17 branch from 8966298 to b5d26cc Compare November 20, 2023 19:55

pedrobaeza reviewed Nov 21, 2023

View reviewed changes

celm1990 added 8 commits November 23, 2023 09:19

[IMP] support copier 9

8fa0ef6

inspired by OCA/oca-addons-repo-template@1e6e78b

[REM] remove old system testing of linters

80615b5

see more details on Tecnativa#425 (comment)

[IMP] upgrade pylint-odoo to support Odoo 17.0

4b29ff6

[REF] testing note or project_todo according odoo version

b3dc0ca

- odoo to V17 change module note and add project_todo, this commit adapt test

[TMP] skip test_backup_config

ada78b7

this test never finished by an unknown reason(for V14.0)

[IMP] Simplify linters using ruff

f4bc534

inspired by OCA/oca-addons-repo-template@299cb36 - remove flake8, isort

[IMP] pre-commit stuff

26bb0c7

[REM] CI: Remove Odoo old version from CI

b3eafd5

Versions from V7 to V10 are skipped in the test, so they should be removed from the CI.

celm1990 force-pushed the main-V17 branch from 1a4e846 to b3eafd5 Compare November 23, 2023 14:23

pedrobaeza approved these changes Nov 23, 2023

View reviewed changes

pedrobaeza merged commit 56ea28e into Tecnativa:main Nov 23, 2023
27 checks passed

celm1990 deleted the main-V17 branch November 23, 2023 23:09

PabloEForgeFlow mentioned this pull request Dec 5, 2023

[IMP] Store ruff's cache in ~/.cache/ruff #434

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] Add option for Odoo 17.0 #425

[ADD] Add option for Odoo 17.0 #425

celm1990 commented Nov 11, 2023 •

edited

Loading

celm1990 commented Nov 12, 2023

pedrobaeza commented Nov 12, 2023

celm1990 commented Nov 12, 2023

celm1990 commented Nov 13, 2023

yajo Nov 13, 2023

celm1990 Nov 13, 2023

pedrobaeza Nov 13, 2023

celm1990 Nov 14, 2023

pedrobaeza Nov 14, 2023

celm1990 Nov 17, 2023

celm1990 commented Nov 17, 2023

celm1990 commented Nov 18, 2023

celm1990 commented Nov 18, 2023

yajo commented Nov 20, 2023 •

edited

Loading

celm1990 commented Nov 20, 2023

celm1990 commented Nov 20, 2023

pedrobaeza commented Nov 20, 2023

celm1990 commented Nov 20, 2023

pedrobaeza commented Nov 20, 2023

pedrobaeza Nov 21, 2023

yajo Nov 21, 2023

pedrobaeza Nov 21, 2023

celm1990 commented Nov 23, 2023

pedrobaeza left a comment

		@@ -1 +1,10 @@
		{%- include "vendor/oca-addons-repo-template/.flake8" -%}
		[flake8]

[ADD] Add option for Odoo 17.0 #425

[ADD] Add option for Odoo 17.0 #425

Conversation

celm1990 commented Nov 11, 2023 • edited Loading

celm1990 commented Nov 12, 2023

pedrobaeza commented Nov 12, 2023

celm1990 commented Nov 12, 2023

celm1990 commented Nov 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

celm1990 commented Nov 17, 2023

celm1990 commented Nov 18, 2023

celm1990 commented Nov 18, 2023

yajo commented Nov 20, 2023 • edited Loading

celm1990 commented Nov 20, 2023

celm1990 commented Nov 20, 2023

pedrobaeza commented Nov 20, 2023

celm1990 commented Nov 20, 2023

pedrobaeza commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

celm1990 commented Nov 23, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

celm1990 commented Nov 11, 2023 •

edited

Loading

yajo commented Nov 20, 2023 •

edited

Loading