Implement a more robust cleanup strategy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeddiO
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like something has changed for linux srcds where it's definitely cleaning up objects, possibly due to how it might be killing the internal processes / memory. Instead of doing an OS check, we check to see now if
instanceis notNULL, and if it isn't we attempt to destroy it.Furthermore, we encapsulate this in the static function
void Fwens::Destroy()so that way the binary has a standard way of dealing with it. Doing it this way means that in future, should anything change in terms of how modules get unloaded on Windows (whereinstancecan become NULL), these changes will already account for that. The same goes for Linux, where if the instance is no longer NULL, we'll attempt to clean it up!Closes #10