Skip to content

Commit

Permalink
fix(XCode16): fix warnings in XCode 16
Browse files Browse the repository at this point in the history
  • Loading branch information
alejandroruizponce authored Oct 3, 2024
1 parent c07498b commit 27adcbd
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 25 deletions.
2 changes: 1 addition & 1 deletion MisticaCatalog/MisticaCatalog.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@
repositoryURL = "https://github.com/microsoft/appcenter-sdk-apple";
requirement = {
kind = exactVersion;
version = 4.3.0;
version = 5.0.5;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ struct EmptyStateCatalogView: View {

// MARK: Helpers

extension EmptyStateAssetType: CustomStringConvertible {
extension EmptyStateAssetType: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .fullWidth:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ struct FeedbackCatalogView: View {
}
}

extension FeedbackStyle: CustomStringConvertible {
extension FeedbackStyle: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .success:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ extension Image {
static let netflixLogo = Image("netflix-logo")
}

extension CellAssetType: CustomStringConvertible {
extension CellAssetType: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .none:
Expand All @@ -148,7 +148,7 @@ extension CellAssetType: CustomStringConvertible {
}
}

extension CellStyle: CustomStringConvertible {
extension CellStyle: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .fullwidth:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ extension SnackbarCatalogView {

// MARK: CustomStringConvertible

extension SnackbarStyle: CustomStringConvertible {
extension SnackbarStyle: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .normal:
Expand All @@ -152,7 +152,7 @@ extension SnackbarStyle: CustomStringConvertible {
}
}

extension SnackbarButtonStyle: CustomStringConvertible {
extension SnackbarButtonStyle: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .large:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ struct TagCatalogView: View {
}
}

extension Tag.Style: CustomStringConvertible {
extension Tag.Style: Swift.CustomStringConvertible {
public var description: String {
switch self {
case .promo:
Expand Down
8 changes: 4 additions & 4 deletions Package.resolved
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"pins" : [
{
"identity" : "lottie-ios",
"identity" : "lottie-spm",
"kind" : "remoteSourceControl",
"location" : "https://github.com/airbnb/lottie-ios.git",
"location" : "https://github.com/airbnb/lottie-spm.git",
"state" : {
"revision" : "7fe8b6f697ae7db4bf0df270119592cb5d502848",
"version" : "4.4.1"
"revision" : "b842598f1295f3ffa1475b1580672d1fe5b83580",
"version" : "4.5.0"
}
},
{
Expand Down
8 changes: 4 additions & 4 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let package = Package(
)
],
dependencies: [
.package(url: "https://github.com/airbnb/lottie-ios.git", exact: "4.4.1"),
.package(url: "https://github.com/airbnb/lottie-spm.git", exact: "4.5.0"),
.package(url: "https://github.com/pointfreeco/swift-snapshot-testing.git", exact: "1.8.2"),
.package(url: "https://github.com/SDWebImage/SDWebImage.git", exact: "5.19.1"),
.package(url: "https://github.com/SDWebImage/SDWebImageSVGCoder.git", exact: "1.7.0")
Expand All @@ -23,7 +23,7 @@ let package = Package(
.target(
name: "MisticaCommon",
dependencies: [
.product(name: "Lottie", package: "lottie-ios")
.product(name: "Lottie", package: "lottie-spm")
],
exclude: [
"Fonts/README.md",
Expand Down Expand Up @@ -57,7 +57,7 @@ let package = Package(
name: "MisticaSwiftUI",
dependencies: [
"MisticaCommon",
.product(name: "Lottie", package: "lottie-ios")
.product(name: "Lottie", package: "lottie-spm")
],
exclude: [
"Components/Button/README.md",
Expand Down Expand Up @@ -101,7 +101,7 @@ let package = Package(
.target(
name: "Mistica",
dependencies: [
.product(name: "Lottie", package: "lottie-ios"),
.product(name: "Lottie", package: "lottie-spm"),
.product(name: "SDWebImage", package: "SDWebImage"),
.product(name: "SDWebImageSVGCoder", package: "SDWebImageSVGCoder"),
"MisticaCommon"
Expand Down
2 changes: 1 addition & 1 deletion Sources/Mistica/Components/Button/Button.swift
Original file line number Diff line number Diff line change
Expand Up @@ -378,4 +378,4 @@ public extension Button.State {
static let loading = UIControl.State(rawValue: 1 << 50) // Arbitrary value
}

extension Button.State: Hashable {}
extension Button.State: Swift.Hashable {}
6 changes: 0 additions & 6 deletions Sources/Mistica/Components/Checkbox/Checkbox.swift
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ private extension Checkbox {
addGestureRecognizer(tapGesture)

isAccessibilityElement = true
setupAccessibilityTraits()
}

func layoutView() {
Expand All @@ -136,11 +135,6 @@ private extension Checkbox {
generator.impactOccurred()
}

@available(iOS, introduced: 11.0, deprecated: 14.0, message: "We're using an undocumented traits of UISwitch. Please verify that this works before increment the deprecated version number")
func setupAccessibilityTraits() {
accessibilityTraits = UISwitch().accessibilityTraits
}

func updateViewStyleAnimated(checked: Bool) {
let duration = Constants.animationDuration

Expand Down
4 changes: 2 additions & 2 deletions Sources/MisticaSwiftUI/Components/Inputfield/InputField.swift
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ public extension InputField {
}

func textContentType(_ textContentType: UITextContentType?) -> InputField {
var view = self
view.textField.textContentType(textContentType)
let view = self
_ = view.textField.textContentType(textContentType)
return view
}
}
Expand Down

0 comments on commit 27adcbd

Please sign in to comment.