Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4727 feat: [GOLIUM][MongoDB] Create_generic_code_working_MongoDB #118

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

antoniodiazplaza
Copy link

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Documentation

Update Readme docs if needed.

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 353 lines in your changes are missing coverage. Please review.

Comparison is base (77eea8a) 63.42% compared to head (977c396) 58.55%.

Files Patch % Lines
steps/mongo/session.go 15.17% 283 Missing and 2 partials ⚠️
steps/mongo/steps.go 0.00% 39 Missing ⚠️
steps/mongo/collection.go 0.00% 14 Missing ⚠️
steps/mongo/client.go 0.00% 8 Missing ⚠️
steps/mongo/context.go 0.00% 6 Missing ⚠️
steps/redis/steps.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   63.42%   58.55%   -4.87%     
==========================================
  Files          48       55       +7     
  Lines        3434     3880     +446     
==========================================
+ Hits         2178     2272      +94     
- Misses       1188     1538     +350     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sarmar11 sarmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolg mariolg changed the title 4727[GOLIUM][MongoDB] Create_generic_code_working_MongoDB 4727 feat: [GOLIUM][MongoDB] Create_generic_code_working_MongoDB Oct 28, 2023
Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.1% 25.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants