handle empty operation id

TelkomIndonesia · Jun 18, 2024 · 7082415 · 7082415
1 parent c5d6dae
commit 7082415
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/internal/proxy/extension.go b/internal/proxy/extension.go
@@ -220,7 +220,9 @@ func (pe *ProxyExtension) compile() (err error) {
 		*op = *uop
 
 		op.Parameters = opParam
-		op.OperationId = opID
+		if opID != "" {
+			op.OperationId = opID
+		}
 		op.Security = opSecurity
 		for m := range orderedmap.Iterate(context.Background(), op.Extensions) {
 			opExt.Set(m.Key(), m.Value())

diff --git a/internal/proxy/templates/upstream/strict/strict-interface.tmpl b/internal/proxy/templates/upstream/strict/strict-interface.tmpl
@@ -13,7 +13,9 @@
     {{range $paramIdx, $param := .PathParams}}
         {{.GoVariableName}} := r.{{.GoName | ucFirst}}
     {{- end}}
+    {{if .RequiresParamObject -}}
         params := r.Params
+    {{end -}}
 
         var err error
     {{range $paramIdx, $param := .PathParams}}

diff --git a/internal/proxy/testoutput/oapi-proxy.go b/internal/proxy/testoutput/oapi-proxy.go