Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMPManager#parsePage(): failOnMissing has no effect #16

Open
Tellus opened this issue Jan 24, 2024 · 0 comments
Open

CMPManager#parsePage(): failOnMissing has no effect #16

Tellus opened this issue Jan 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Tellus
Copy link
Owner

Tellus commented Jan 24, 2024

I noticed that failOnMissing actually doesn't throw when no CMP could be found. Looks like it was attached to some code that was commented out at some point.

Not sure if it should be re-enabled or removed (always expect errors on failures or always check for null?).
@Tellus Tellus added the bug Something isn't working label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tellus