Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements | Modeling #15

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Improvements | Modeling #15

merged 5 commits into from
Jul 8, 2024

Conversation

Sergio-e
Copy link
Collaborator

@Sergio-e Sergio-e commented Jul 5, 2024

Relevant changes

  • Add missing constraints and indexes
  • Add validations
  • Use has_and_belongs_to_many on many-to-many associations
  • Add factories
  • Add seeds

t.string :bio
t.string :location
t.string :github_url
t.string :linkedin_url
t.string :twitter_url
t.boolean :public
t.boolean :is_public
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to is_public because public is a reserved Ruby keyword

@Sergio-e Sergio-e marked this pull request as ready for review July 5, 2024 21:36
@Sergio-e Sergio-e self-assigned this Jul 5, 2024
@LuigiR0jas LuigiR0jas merged commit f31cca5 into main Jul 8, 2024
4 checks passed
@LuigiR0jas LuigiR0jas deleted the improvements-modeling branch July 8, 2024 21:45
@LuigiR0jas LuigiR0jas linked an issue Jul 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modeling improvements
2 participants