Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guest mode #154

Merged
merged 15 commits into from
Sep 3, 2024
Merged

Add guest mode #154

merged 15 commits into from
Sep 3, 2024

Conversation

davilajose23
Copy link
Collaborator

@davilajose23 davilajose23 commented Aug 29, 2024 •
edited
Loading

Description

This PR adds the possibility to see the sessions without an account.

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

image

andresag4
andresag4 requested changes Sep 3, 2024
View reviewed changes
app/controllers/abouts_controller.rb Outdated Show resolved Hide resolved
app/controllers/sessions_controller.rb Outdated Show resolved Hide resolved
app/models/session.rb Show resolved Hide resolved
app/queries/session_query.rb Outdated Show resolved Hide resolved
app/controllers/speakers_controller.rb Outdated Show resolved Hide resolved
app/views/layouts/_bottom_navbar.html.erb Outdated Show resolved Hide resolved
app/views/layouts/_bottom_navbar.html.erb Outdated Show resolved Hide resolved
andresag4
andresag4 requested changes Sep 3, 2024
View reviewed changes
app/helpers/navigation_helper.rb Outdated Show resolved Hide resolved
davilajose23 and others added 10 commits September 3, 2024 11:24
@davilajose23 @andresag4
Update app/controllers/abouts_controller.rb
fe0fd92 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/controllers/sessions_controller.rb
abe7cf5 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/queries/session_query.rb
3e3c52f 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/helpers/navigation_helper.rb
349e44f 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/views/layouts/_bottom_navbar.html.erb
1bb387a 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/controllers/speakers_controller.rb
2d21de0 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23 @andresag4
Update app/views/layouts/_bottom_navbar.html.erb
9b79e8a 
Co-authored-by: Andres Alvidrez <andres.ag4@hotmail.com>
@davilajose23
add safe navigators and fix
62082c8
@davilajose23
fix
3fbf225
@andresag4
remove unnecessary if
fb51995
davilajose23 and others added 2 commits September 3, 2024 15:10
@andresag4 andresag4 merged commit bbb1e86 into main Sep 3, 2024
4 checks passed
@andresag4 andresag4 deleted the guest_mode branch September 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresag4 andresag4 andresag4 approved these changes

@Sergio-e Sergio-e Awaiting requested review from Sergio-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davilajose23 @andresag4