Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable form buttons and better errors #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable form buttons and better errors #176

wants to merge 2 commits into from

Conversation

Sergio-e
Copy link
Collaborator

Description

Please include a summary of the change. Also, include any additional information that you think is important for reviewers to know. Link to a related issue if applicable.

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

This section is relevant in case we want to share progress with the team, otherwise, it can be omitted.

"w-full bg-red py-4 text-white font-black italic rounded-[10px] uppercase",
"disabled:bg-gray-400 disabled:cursor-not-allowed"
]
) %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not caused by this PR but fields with errors input gets shortened
image
image

We could easily fix it by adding this to application.tailwind.css

div.field_with_errors {
  @apply w-full;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants