Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QR Code generation and sharing #50

Merged
merged 28 commits into from
Jul 30, 2024
Merged

Add QR Code generation and sharing #50

merged 28 commits into from
Jul 30, 2024

Conversation

andresag4
Copy link
Collaborator

@andresag4 andresag4 commented Jul 15, 2024 •
edited
Loading

Description

Added Profile#show with QR code and sharing and scanning options
Create a new user with profile, navigate to /profiles/#{profile.uuid}
See results

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

Profile Show

image

Save QR Code

Downloads file directly
image

Share

Prompts share dialog from Phone
Desktop version: downloads file directly
image

Scan a code

Directly opens phone camera
Desktop version: prompts choosing a file

@andresag4 andresag4 linked an issue Jul 15, 2024 that may be closed by this pull request
QR Code Generation #22
Closed
@andresag4 andresag4 force-pushed the 22-qr-code-generation branch 5 times, most recently from bedefc8 to ebcef53 Compare July 15, 2024 23:07
@davilajose23 davilajose23 requested review from davilajose23 and removed request for LuigiR0jas and Sergio-e July 19, 2024 01:41
@davilajose23
Copy link
Collaborator

@andresag4 could you add a brief description of the PR and a list of all the tasks done?

davilajose23
davilajose23 reviewed Jul 19, 2024
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
davilajose23
davilajose23 reviewed Jul 19, 2024
View reviewed changes
app/models/profile.rb Outdated Show resolved Hide resolved
davilajose23
davilajose23 reviewed Jul 19, 2024
View reviewed changes
app/models/profile.rb Outdated Show resolved Hide resolved
@andresag4 andresag4 force-pushed the 22-qr-code-generation branch 2 times, most recently from 97cda7c to dafab43 Compare July 24, 2024 21:16
davilajose23
davilajose23 reviewed Jul 29, 2024
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
davilajose23
davilajose23 reviewed Jul 30, 2024
View reviewed changes
config/routes.rb Outdated Show resolved Hide resolved
@LuigiR0jas LuigiR0jas merged commit e007d28 into main Jul 30, 2024
4 checks passed
@LuigiR0jas LuigiR0jas deleted the 22-qr-code-generation branch July 30, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davilajose23 davilajose23 davilajose23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QR Code Generation
3 participants
@andresag4 @davilajose23 @LuigiR0jas