Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS PWA enhancements #96

Merged
merged 10 commits into from
Sep 2, 2024
Merged

iOS PWA enhancements #96

merged 10 commits into from
Sep 2, 2024

Conversation

aliciapaz
Copy link
Contributor

Description

In iOS, using black-translucent in the apple-mobile-web-app-status-bar-style for the status bar will take the same background color as the body element. Hence this change.

How has this been tested?

Using Xcode iOS simulator (See screenshot below)

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Screenshots/Loom

image

@aliciapaz aliciapaz self-assigned this Aug 9, 2024
@aliciapaz aliciapaz requested review from EdgarB and LuigiR0jas and removed request for EdgarB August 9, 2024 00:33
@aliciapaz aliciapaz changed the title Make iOS use the theme color in status bar iOS PWA enhancements Aug 9, 2024
@LuigiR0jas LuigiR0jas merged commit aa979b4 into main Sep 2, 2024
4 checks passed
@LuigiR0jas LuigiR0jas deleted the fix/pwa-ios-status-bar branch September 2, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants