fix(ios): occasional crash of CFRunloop in looper driver

Tencent · Jan 3, 2025 · 785aa6c · 785aa6c
1 parent ea8f280
commit 785aa6c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/modules/footstone/src/platform/ios/looper_driver.cc b/modules/footstone/src/platform/ios/looper_driver.cc
@@ -48,6 +48,8 @@ LooperDriver::LooperDriver(): loop_() {
 LooperDriver::~LooperDriver() {
   CFRunLoopTimerInvalidate(delayed_wake_timer_);
   CFRunLoopRemoveTimer(loop_, delayed_wake_timer_, kCFRunLoopDefaultMode);
+  CFRelease(delayed_wake_timer_);
+  CFRelease(loop_);
 }
 
 void LooperDriver::Notify() {
@@ -63,7 +65,9 @@ void LooperDriver::WaitFor(const TimeDelta& delta, std::unique_lock<std::mutex>&
 }
 
 void LooperDriver::Start() {
+  // note that `loop_` created on dom thread but release on main thread
   loop_ = CFRunLoopGetCurrent();
+  CFRetain(loop_);
   CFRunLoopAddTimer(loop_, delayed_wake_timer_, kCFRunLoopDefaultMode);
   while (true) {
     if (IsExitImmediately()) {