Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support-hippy-vue-next-ssr #3526

Merged
merged 74 commits into from
Jan 19, 2024

Conversation

gguoyu
Copy link
Collaborator

@gguoyu gguoyu commented Sep 22, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

gguoyu added 30 commits March 2, 2023 21:11
# Conflicts:
#	examples/hippy-vue-next-demo/package.json
#	examples/ios-demo/HippyDemo.xcodeproj/project.pbxproj
#	examples/ios-demo/res/index.ios.js
#	packages/hippy-vue-next/src/runtime/element/hippy-element.ts
@hippy-service
Copy link

hippy-service bot commented Sep 22, 2023

Hi, @gguoyu. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Sep 22, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.


// unescape
str = str.replace(/"/g, '"');
str = str.replace(/&/g, '&');

Check failure

Code scanning / CodeQL

Double escaping or unescaping

This replacement may produce '&' characters that are double-unescaped [here](1).
Comment on lines +208 to +210
context.pushStringPart(`{"id": -1,"name":"comment","props":{"text":"${child.content
.replace(/\n/g, ' ')
.replace(/"/g, '\\"')}"}},`);

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This does not escape backslash characters in the input.
Comment on lines +208 to +210
context.pushStringPart(`{"id": -1,"name":"comment","props":{"text":"${child.content
.replace(/\n/g, ' ')
.replace(/"/g, '\\"')}"}},`);

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This does not escape backslash characters in the input.

// unescape
str = str.replace(/"/g, '"');
str = str.replace(/&/g, '&');

Check failure

Code scanning / CodeQL

Double escaping or unescaping High

This replacement may produce '&' characters that are double-unescaped
here
.
Copy link

hippy-service bot commented Dec 6, 2023

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Dec 6, 2023
zealotchen0
zealotchen0 previously approved these changes Jan 19, 2024
# Conflicts:
#	docs/en-us/hippy-vue/vue3.md
#	docs/hippy-vue/vue3.md
Copy link

hippy-service bot commented Jan 19, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

Copy link

hippy-service bot commented Jan 19, 2024

After a quick scan, I have approved workflow to run.

@zealotchen0 zealotchen0 merged commit 952f2f7 into Tencent:master Jan 19, 2024
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build: js doc: example doc: pages driver: js size: xl Denotes a PR that changes 1000+ lines stale: 60d No interaction in the last 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants