-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support-hippy-vue-next-ssr #3526
Feature/support-hippy-vue-next-ssr #3526
Conversation
# Conflicts: # examples/hippy-vue-next-demo/package.json # examples/ios-demo/HippyDemo.xcodeproj/project.pbxproj # examples/ios-demo/res/index.ios.js # packages/hippy-vue-next/src/runtime/element/hippy-element.ts
Hi, @gguoyu. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
After a quick scan, I have approved workflow to run.
🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators. |
|
||
// unescape | ||
str = str.replace(/"/g, '"'); | ||
str = str.replace(/&/g, '&'); |
Check failure
Code scanning / CodeQL
Double escaping or unescaping
context.pushStringPart(`{"id": -1,"name":"comment","props":{"text":"${child.content | ||
.replace(/\n/g, ' ') | ||
.replace(/"/g, '\\"')}"}},`); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
context.pushStringPart(`{"id": -1,"name":"comment","props":{"text":"${child.content | ||
.replace(/\n/g, ' ') | ||
.replace(/"/g, '\\"')}"}},`); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
|
||
// unescape | ||
str = str.replace(/"/g, '"'); | ||
str = str.replace(/&/g, '&'); |
Check failure
Code scanning / CodeQL
Double escaping or unescaping High
here
Pay attention 🛎️ !! |
# Conflicts: # docs/en-us/hippy-vue/vue3.md # docs/hippy-vue/vue3.md
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
After a quick scan, I have approved workflow to run.
|
Before submitting a new pull request, please make sure: