Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix ios thread joinable terminate crash #4165

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(core): fix ios thread joinable terminate crash #4165

merged 1 commit into from
Jan 3, 2025

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Jan 3, 2025

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added framework: ios size: xs Denotes a PR that changes 0-9 lines labels Jan 3, 2025
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2025

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

wwwcg
wwwcg approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wwwcg wwwcg merged commit 9a4674c into Tencent:main Jan 3, 2025
37 checks passed
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2025

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 3, 2025
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Jan 3, 2025

⚠️ rebase-merge action execution failed, because of auto rebase and merge failed.

Please check the following details:

GraphQL: Can't disable auto-merge for this pull request. (disablePullRequestAutoMerge)

#help

@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed framework: ios size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @wwwcg