Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ohos): fix remote server url parse #4179

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

zealotchen0
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@zealotchen0 zealotchen0 requested a review from etkmao as a code owner January 22, 2025 10:09
@github-actions github-actions bot added the size: xs Denotes a PR that changes 0-9 lines label Jan 22, 2025
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Jan 22, 2025

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link
Collaborator

@etkmao etkmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

hippy-service bot commented Jan 22, 2025

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 22, 2025
@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 22, 2025 10:13
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 22, 2025
@zealotchen0 zealotchen0 disabled auto-merge January 22, 2025 10:42
@zealotchen0 zealotchen0 merged commit 5d1df73 into Tencent:main Jan 22, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants