Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image extraction with Take a Screenshot #199

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix image extraction with Take a Screenshot #199

merged 1 commit into from
May 7, 2024

Conversation

DaPigGuy
Copy link
Contributor

@DaPigGuy DaPigGuy commented May 2, 2024 •
edited
Loading

This problem was caused by two separate issues:

  1. The file names passed to Image.Open were escaped (e.g. " " -> "%20")
  2. Frog tries to delete the file after text extraction but might not have the permissions to do so under a sandbox

Closes #192, #182

@height Height
Copy link

height bot commented May 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@DaPigGuy
Fix image extraction with Take a Screenshot
96396a6 
This problem was caused by two separate issues:
1) The file names passed to `Image.Open` were escaped (e.g. " " -> "%20")
2) Frog tries to delete the file after text extraction but might not have the permissions to do so under a sandbox

Closes #192
@amka amka merged commit 18a7ec0 into TenderOwl:master May 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amka amka amka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Failed to decode data"
2 participants
@DaPigGuy @amka