Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: general orientation bug #23

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Fixed: general orientation bug #23

merged 3 commits into from
Apr 7, 2020

Conversation

casals
Copy link
Contributor

@casals casals commented Aug 12, 2019

Contains

Objective

This is a continuation of PR #16 on the subject of mitigating the synchronized stray behavior. This PR fixes the "general orientation"bug inserted by PR #16 and mitigates the visual flipping effect of creatures. The latter is caused by a orientation change derived from the movement to a neighbor block, which causes the impression that the creature just flipped its original orientation to a new one. This effect is mitigated by forcing a higher minimal number of neighbor interactions when setting the target destination for the creature, which causes it to statistically choose a farther destination, and therefore making a perceptible movement when changing its original orientation. The mitigation is statistical since the number of interactions over an initial list of neighbor blocks is based on a random function, and there's a change that after a number of interactions the target destination is still set to a neighbor block.

Changes

  • Removed yaw reset on MoveTo action
  • Increased the number of neighbor interactions on SetTargetToNearbyBlockNode.findRandomNearbyBlock()
  • Refactoring: renamed FleeComponent to FleeingComponent and all related references

…flipping behavior

Handle `DoDamageEvent`'s movement

Revert "Handle `DoDamageEvent`'s movement"

This reverts commit a7b4e90.

Make MinionMoveComponent.path a transient field

Removed position reset bug inserted in the previous PR and mitigated
flipping behavior

Removed position reset bug inserted in the previous PR and mitigated
flipping behavior
@skaldarnar skaldarnar merged commit 0928e65 into Terasology:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants