-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement state machine to model game state #256
Draft
skaldarnar
wants to merge
52
commits into
develop
Choose a base branch
from
feat/state-machine
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move `Phase` enum out of `PhaseSystem` - simplify `Phase` enum (for now) - remove separate components for phases - fix `start/end..Phase` methods
- create authority package for encapsulation - enhance phase enum with event suppliers - use event suppliers to generalize phase transition in PhaseSystem
…mand arguments The parsing of the in-game console arguments is handled by central `ParameterAdapter`s. Modules can register new adapters to extend the support for custom types. This adds support for the `Phase` enum to be used in the in-game console.
- replace `PregameEvent` with `OnPreGamePhaseStartedEvent`
- update method in GameEntitySystem that can be called to update stats on-demand
- move commands to GameEntitySystem
- use configurable minTeamSize instead of static value - use broadcast OnPreGamePhaseStartedEvent instead of GameStartMesssage event
This comment was marked as resolved.
This comment was marked as resolved.
- only in pre-game and countdown phases - only if player is neither spectator (white team) nor unassigned
…ase when countdown finished
- create PlayerExitedArenaEvent - on arena exit remove AllowShopScreenComponent (players only need the shop in-game) - move check for condition changes that trigger a phase change into LASSystem - switch player to white team instead of removing LASTeam component - trigger arena exit clean up actions for disconnecting clients before they are disconnected (requires MovingBlocks/Terasology#5077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.