Consistently draw text with shadows #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prospector
pushed a commit
that referenced
this pull request
Jun 15, 2024
- Fixed text not having shadows properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Mod Menu drew some text with shadows and some text without shadows. The lack of shadows on some text was less of an issue because the text was rendered on a contrasting dirt background. With Minecraft 1.20.5 using a panorama background instead, the lack of shadows on text now impacts the text's visibility.
This pull request updates text drawn without shadows to now have shadows:
Note that badges are not affected by this change, as they are always rendered on top of a background specifically chose to contrast with the text color.