Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash on 24w18a when clicks the ModMenuOptions of this mod #729 #730

Closed
wants to merge 3 commits into from

Conversation

sdy623
Copy link

@sdy623 sdy623 commented May 10, 2024

#729

The class GameOptionsScreen in 24w18a changed to an abstract class. So the edit of ModMenuModMenuCompat is needed.

1.20.6

public class GameOptionsScreen extends Screen 

24w18a

public abstract class GameOptionsScreen extends Screen 

So the edit of this is needed. Otherwise, the remap and compile won't success.

clicks the ModMenuOptions of this mod it crashes
because the class GameOptionsScreen in 24w18a
changed to abstract class. So the edit of
ModMenuModMenuCompat is needed.
@haykam821
Copy link
Contributor

Thank you for the contribution! This pull request was superseded by #734, which ports Mod Menu to a newer Minecraft version, so I will close this pull request. Version 11.0.0 beta 1 supports Minecraft 1.21 pre-release 2.

@haykam821 haykam821 closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants