Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries registry provider for asab.library #507

Merged
merged 25 commits into from
Oct 24, 2023
Merged

Conversation

ateska
Copy link
Contributor

@ateska ateska commented Oct 8, 2023

This MR adds another library provider for asab.library: Libraries registry provider.
This provider enables a smooth content distribution (technically over HTTPS) and provides an alternative for Git provider.
The content is prepared (ie by CI/CD) as an .tar.xz archive on the HTTPS static web site (such as Azure storage) and this provider periodically downloads it and unpack locally - similarly to git.
It also provides caching, so if the content has not been changed, nothing is downloaded.

It implements the fallback mechanism: multiple servers can be specified in the URI so that the content can be distributed from multiple location, providing higher resiliency.

The URL & configuration form:

[library]
providers=
  ...
  libsreg+https://server1.example.com,server2.example.com/my-library#version
  ...

If version is not provided, then master is used.

Copy link
Contributor Author

@ateska ateska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Copy link
Contributor Author

@ateska ateska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below.

f.write(etag_incoming)

# TODO: Remove temp_extract_dir
# TODO: Remove newtarfname
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added TODOs into - slightly refactored - code during the review process.
@mithunbharadwaj - please implement these TODOs.

@sedoy26 sedoy26 merged commit 8a47baf into master Oct 24, 2023
8 checks passed
@ateska ateska deleted the feature/library-libsreg branch November 2, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants