feat: Add FileVersionInfo support

[t4m45]

Added a wrapper for the immutable FileVersionInfo.

For testing, the IFileVersionInfo can be stored in the MockFileData as a property.
Since testing it is rarely neccessary, I didn't add a constructor for it but it's a mutable property, so it can be set anytime after initialization.
A MockFileVersionInfo has also been added which is mutable.

In a normal scenario, the FileVersionInfo can be accessed through the FileVersionInfo property of IFileInfo.

The MockFileSystem's AddFile method will initialize this version if it's null, and the values will be the default (Only it's FileName will be set).

Since the System.IO.FileInfo does not contain a FileVersionInfo property, I excluded it from the ApiParityTests

PS.: Sorry, seems like were some auto formats on my side which removed some extra spaces and the Visual Studio's Diff viewer did not show these before commit. I'm not really familiar with github, thats why I didn't try to revert them after commit.

[vbreuss]

Thanks for suggesting this change, @t4m45!

While I do like the idea of adding support for FileVersionInfo, I don't like adding it to the IFileInfo interface, as this is different to the public API.

Instead I would suggest adding a IFileInfoFactory to the IFileSystem with a static method GetVersionInfo(string) which returns an instance of IFileInfo. This way you could use it as follows:

// Instead of
FileVersionInfo version = FileVersionInfo.GetVersionInfo("my-library.dll");
// you can use
MockFileSystem fileSystem = new();
IFileVersionInfo version = fileSystem.FileVersionInfo.GetVersionInfo("my-library.dll");

This works the same way as the existing API. You could then adapt the parity tests, to also verify, that the interface IFileVersionInfo matches FileVersionInfo.

Would you be willing to adapt your pull request as suggested?

[t4m45]

Hello @vbreuss!

Just for clarity, in the sentence "I would suggest adding a IFileInfoFactory to the IFileSystem with a static method GetVersionInfo(string) which returns an instance of IFileInfo"

Did you mean 'IFileVersionInfoFactory' and 'IFileVersionInfo' instead of 'IFileInfoFactory' and 'IFileInfo'?

[t4m45]

Also, since I'm not really familiar with Github, can you please help me how can I change my pull request?
After changing the code in my fork, what should I do?

Thanks.

[t4m45]

I implemented the factory you asked for, and removed the FileVersionInfo from IFileInfo.

[vbreuss]

Even though I have some comments, I am impressed by the overall approach; great work!

[t4m45]

When it comes to the MockFileVersionInfoFactory, I'm not sure how to fix the issue reported by Codacy: "Remove this assignment of 'mockFileSystem' or initialize it statically."

If you're okay with it, I can remove the constructor, create a static method called SetFileDataAccessor, and inject it that way.
But if you have another idea, I'm all ears.

[vbreuss]

When it comes to the MockFileVersionInfoFactory, I'm not sure how to fix the issue reported by Codacy: "Remove this assignment of 'mockFileSystem' or initialize it statically."

If you're okay with it, I can remove the constructor, create a static method called SetFileDataAccessor, and inject it that way. But if you have another idea, I'm all ears.

You should not use a static field in the MockFileVersionInfoFactory.
If you make the following changes, it should build without errors:

I will have a more in-depth look at the pull request after christmas...

[t4m45]

You should not use a static field in the MockFileVersionInfoFactory. If you make the following changes, it should build without errors:

Well, I know that. The only reason I made the method static is because thats what you asked for.

Instead I would suggest adding a IFileInfoFactory to the IFileSystem with a static method GetVersionInfo(string) which returns an instance of IFileInfo.

But I will change it then.

By the way, every mock factory uses the interface IMockFileDataAccessor instead of the MockFileSystem implementation, so I think it's better I'm not changing the type. I'll only remove the static declarations.

[vbreuss]

Well, I know that. The only reason I made the method static is because thats what you asked for.

Sorry, that was misleading by me. I meant, that you should mimick the static method in the System.Diagnostics namespace the same way we mimick the static File methods (by instance methods on a factory class)...

[vbreuss]

I have only found some minor comments.
Please also update the version in version.json to "21.2".

[vbreuss]

Looks good to me, thanks a lot!

[t4m45]

Awesome! Thank you for the help!

[github-actions]

This is addressed in release v21.2.1.