Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: don't use cell sg13g2_sdfbbp_1 #2493

Closed
wants to merge 1 commit into from

Conversation

htfab
Copy link

@htfab htfab commented Oct 22, 2024

Yosys can only infer flip-flops where the next_state property in the liberty file is a single pin or its negation. For sg13g2_sdfbbp_1 it is (SCE*SCD)+(SCE'*D) so it prints a warning and ignores the cell. By adding the cell to the DONT_USE_CELLS list we can get rid of the warning.

Signed-off-by: htfab <mpw@htamas.net>
@maliberty
Copy link
Member

@povik a scan flop seems like an ordinary thing - why can't yosys handle this cell?

@povik
Copy link

povik commented Oct 22, 2024

@maliberty With YosysHQ/yosys#4652 we are extending the next_state handling to deal with arbitrary expressions, by which we should get rid of the warning in question.

Is there anything you would expect a synthesis tool to do with a scan flop other than ignore it?

@maliberty
Copy link
Member

I would hope it would quietly ignore it. Putting it in the DONT_USE lists suggests that it should never be used (should DFT ignore it too?).

Is there an ETA to land that PR?

@povik
Copy link

povik commented Oct 22, 2024

Is there an ETA to land that PR?

My estimate is the start of December release.

@maliberty
Copy link
Member

@htfab are you ok to wait ~1 month to have this resolved by yosys? If not we can merge but will need to track reverting this then.

@htfab
Copy link
Author

htfab commented Oct 22, 2024

I'm ok with waiting. We are using it in Tiny Tapeout, but we already have a script that patches it on our side, so it just means we keep that script for somewhat longer.

@maliberty maliberty closed this Oct 22, 2024
@maliberty
Copy link
Member

This will resolve automatically when the right yosys update happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants