Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] gcc >= 13 reordered headers. #2710

Open
realstealthninja opened this issue Aug 21, 2024 · 4 comments · May be fixed by #2717
Open

[BUG] gcc >= 13 reordered headers. #2710

realstealthninja opened this issue Aug 21, 2024 · 4 comments · May be fixed by #2717
Labels

Comments

@realstealthninja
Copy link
Collaborator

Description

#2702 mentions reports of algorithms failing to compile due to a reordering of the headerfiles. Including cstdint would be better practice too.

Expected behavior

all typedefs of primitive types containing files compiles

Actual behavior

Compilation failure

Steps to reproduce

  1. Use gcc >= 13
  2. Run cmake build on any of the algorithm containing typedefs like uint8_t

Context

Requiring temporary inclusions of cstdint before creating changes then removing them for the actual pr

Additional information

No response

@realstealthninja
Copy link
Collaborator Author

dockcross/dockcross#832 is another example of users being affected

@realstealthninja
Copy link
Collaborator Author

realstealthninja commented Aug 31, 2024

Merged #2702
If you find more examples please raise a pull request

@realstealthninja
Copy link
Collaborator Author

81 files are affected. currently going to each and every file and manually adding headers.

@realstealthninja
Copy link
Collaborator Author

@VirtualTim happy to report we have pr that will fix the gcc reordering issue

@realstealthninja realstealthninja changed the title gcc >= 13 reordered headers. [BUG] gcc >= 13 reordered headers. Sep 1, 2024
@realstealthninja realstealthninja added bug and removed bug good first issue Good for newcomers labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant