Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cholesky_decomposition.py #11848

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

99991
Copy link

@99991 99991 commented Oct 7, 2024

Describe your change:

This PR adds the Cholesky decomposition and how to use it to solve a linear system of equations.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link

@jeffreyyancey jeffreyyancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite good. To meet the guidelines lo and s can be changed to fully named variables. I also added a couple tentative suggestions that I think could improve the good work you already have here.

maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names awaiting reviews This PR is ready to be reviewed labels Oct 9, 2024
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
maths/cholesky_decomposition.py Outdated Show resolved Hide resolved
@99991
Copy link
Author

99991 commented Oct 10, 2024

I renamed the variables again. I think the code is harder to follow now since the variable names do not match the equations on Wikipedia anymore, but at least the stupid bot is happy.

@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants