Create travelling_salesman_problem.py #11939
Conversation
added travelling salesman problem under dynamic programming
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| visited_all = (1 << n) - 1 | ||
|
|
||
| @lru_cache(None) | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| visited_all = (1 << n) - 1 | ||
|
|
||
| @lru_cache(None) | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| visited_all = (1 << n) - 1 | ||
|
|
||
| @lru_cache(None) | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| raise ValueError("Distance cannot be negative") | ||
| visited_all = (1 << n) - 1 | ||
| @lru_cache(None) | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| visited_all = (1 << n) - 1 | ||
|
|
||
| @lru_cache(None) | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Memoization table | ||
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Memoization table | ||
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| #!/usr/bin/env python3 | ||
|
|
||
|
|
||
| def tsp(distances: list[list[int]]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function tsp
| memo = [[-1] * (1 << n) for _ in range(n)] | ||
| visited_all = (1 << n) - 1 # All cities visited mask | ||
|
|
||
| def visit(city: int, mask: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/travelling_salesman_problem.py, please provide doctest for the function visit
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
|
Closing require_tests PRs to prepare for Hacktoberfest |
added travelling salesman problem under dynamic programming
Describe your change:
Checklist: