Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed entropy calculations and more #54

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Fixed entropy calculations and more #54

merged 6 commits into from
Aug 7, 2024

Conversation

ashkjones
Copy link
Collaborator

fixes #51 and fixes #52

  • Rows that are not assigned explicitly to an AOI are treated as belonging to a single "Undefined Area" AOI in the entropy calcs
  • The "No AOI" label was changed to "Undefined Area" because now it is being treated as first-class AOI, i.e., it is considered an AOI in all calculations relating to AOIs
  • I fixed a filtering bug I introduced in PR Fix saccade velocity sorting #53
  • Moved header string constants and screen size to a package-private final class with static fields, called constants. This class cannot be instantiated and only acts as a place to share constants between other classes in the package rather than have each class re-declare its own copy over and over again. This will help if gazepoint ever changes their output format/headers; we only need to change the strings in one place.

relates to #51 and #52. Data reocords with no AOI value are treated as though they belong to an AOI ("Undefined Area") in the entropy calcs. No Aoi is renamed to "Undefined Area" because now it is an AOI in a sense
blinks were 0 because filtering was being applied so i reworked analysis class. There was a lot of redundant final constants so I put them in one class so it would be easier to manage. I applied the screen size once and then made an overloaded filterbyvalidity method to support filtering with a screen size
@ashkjones ashkjones merged commit 436cdda into main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with "No AOI" in Transition Entropy Incorrect Transition Entropy
1 participant