Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues and add more tests #58

Merged
merged 13 commits into from
Aug 15, 2024
Merged

Fix some issues and add more tests #58

merged 13 commits into from
Aug 15, 2024

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    9372904 View commit details
    Browse the repository at this point in the history
  2. Made AreaOfInterests methods more modular to improve testability

    Separated longer methods into multiple methods. Changed variable names to be be more distinct and readable. Removed unused lines of code. Made function accept interfaces list or map to shorten the definition. Underlying implementation is not changed.
    ashkjones committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7d02bfe View commit details
    Browse the repository at this point in the history
  3. override DataEntry equals method

    equals now returns true if the data entries have the same headers and data. This is useful for testing
    ashkjones committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6327580 View commit details
    Browse the repository at this point in the history
  4. Add tests for AreasOfInterests and exit earlier if no AOIs

    need to add more tests once Analysis class is done
    ashkjones committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e2ce087 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b91e68f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    ccbc41b View commit details
    Browse the repository at this point in the history
  2. Removed excess double brace initialization from tests

    I was terribly misguided when I first wrote the tests. The new initialization of objects should reduce the byte code and increase testing/building speeds
    ashkjones committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    798a90f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    46e1487 View commit details
    Browse the repository at this point in the history
  2. Fixed one off pattern issue in #55

    Last pattern was not included in a sequence. Also set the minimums to always be positive to prevent breaking the looping constraints or index out of bounds. Changed the names of variables in Analysis class to make it more clear what sequences are being handled. Used List.of in Analysis class becuase it is structurally immutable (which is safer when not expecting the list to be modified in place)
    ashkjones committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b0d8b87 View commit details
    Browse the repository at this point in the history
  3. Added tests for Patterns class

    maybe not the most exhaustive list of tests, but should be able to catch major mistake if the class is edited. Also, it appears the the PPF divisor is number of patterns of the same length. This appears to be desired behavior based on the commit message 9759aff
    ashkjones committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f21c31e View commit details
    Browse the repository at this point in the history
  4. add Event unit tests

    ashkjones committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a3ef7ab View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Separated Window patterns into separate methods and added tests

    made methods smaller to make testing easier. Moved getting baseline outside event window method to reduce the number of dependencies in a single method
    ashkjones committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    feebcd1 View commit details
    Browse the repository at this point in the history
  2. Made baseline data passed through memory rather than read from file a…

    …gain.
    
    Removed unnecessary file reads to make testing easier and code more modular.
    ashkjones committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d497a11 View commit details
    Browse the repository at this point in the history