Skip to content

Commit

Permalink
Fix height of webview bug
Browse files Browse the repository at this point in the history
  • Loading branch information
TheFinestArtist committed Jan 26, 2016
1 parent d515f02 commit 5a707df
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Easily reference the library in your Android projects using this dependency in y

```java
dependencies {
compile 'com.thefinestartist:finestwebview:1.1.4'
compile 'com.thefinestartist:finestwebview:1.1.5'
}
```

Expand Down
4 changes: 2 additions & 2 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ android {
minSdkVersion 7
targetSdkVersion 23
versionCode 1
versionName "1.1.4"
versionName "1.1.5"
}
}

Expand All @@ -34,7 +34,7 @@ publish {
userOrg = 'thefinestartist'
groupId = 'com.thefinestartist'
artifactId = 'finestwebview'
publishVersion = '1.1.4'
publishVersion = '1.1.5'
desc = 'Beautiful and customizable Android Activity that shows web pages within an app.'
website = 'https://github.com/TheFinestArtist/FinestWebView-Android'
}
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,14 @@ protected void layoutViews() {
}
progressBar.setLayoutParams(params);
}

{ // WebLayout
float toolbarHeight = getResources().getDimension(R.dimen.toolbarHeight);
int screenHeight = ScreenHelper.getHeight(this);
float webLayoutMinimumHeight = screenHeight - toolbarHeight;
if (showDivider && !gradientDivider) webLayoutMinimumHeight -= dividerHeight;
webLayout.setMinimumHeight((int) webLayoutMinimumHeight);
}
}

@SuppressLint("SetJavaScriptEnabled") protected void initializeViews() {
Expand Down
2 changes: 1 addition & 1 deletion sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ android {
minSdkVersion 7
targetSdkVersion 23
versionCode 9
versionName "1.1.4"
versionName "1.1.5"
}
buildTypes {
release {
Expand Down

0 comments on commit 5a707df

Please sign in to comment.