Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G3 194 gene list endpoint #38

Merged
merged 3 commits into from
Mar 20, 2024
Merged

G3 194 gene list endpoint #38

merged 3 commits into from
Mar 20, 2024

Conversation

francastell
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited
Loading

Test Coverage Report

============================= test session starts ==============================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /home/runner/work/geneweaver-api/geneweaver-api
plugins: anyio-4.3.0, asyncio-0.21.1, cov-4.1.0
asyncio: mode=Mode.STRICT
collected 83 items

tests/controllers/test_genes.py ............                             [ 14%]
tests/controllers/test_genesets.py ...........                           [ 27%]
tests/controllers/test_publications.py .....                             [ 33%]
tests/controllers/test_species.py ...                                    [ 37%]
tests/core/test_security.py ..........                                   [ 49%]
tests/services/test_gene.py ............                                 [ 63%]
tests/services/test_genset.py ........                                   [ 73%]
tests/services/test_publications.py ..                                   [ 75%]
tests/services/test_species.py .....                                     [ 81%]
tests/services/io/test_read_file_contents.py ...............             [100%]

=============================== warnings summary ===============================
tests/data/__init__.py:10
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:10: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    geneset_response_json = importlib.resources.read_text(

../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
../../../../../opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80
  /opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py:80: DeprecationWarning: open_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    with open_text(package, resource, encoding, errors) as fp:

tests/data/__init__.py:13
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:13: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    geneset_w_gene_id_type_json = importlib.resources.read_text(

tests/data/__init__.py:17
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:17: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    gene_homologus_ids_json = importlib.resources.read_text(

tests/data/__init__.py:21
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:21: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    gene_id_mapping_json = importlib.resources.read_text("tests.data", "gene_maping.json")

tests/data/__init__.py:23
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:23: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    publications_json = importlib.resources.read_text("tests.data", "publications.json")

tests/data/__init__.py:25
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:25: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    jwt_test_keys_json = importlib.resources.read_text(

tests/data/__init__.py:29
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:29: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    species_json = importlib.resources.read_text("tests.data", "species.json")

tests/data/__init__.py:31
  /home/runner/work/geneweaver-api/geneweaver-api/tests/data/__init__.py:31: DeprecationWarning: read_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    genes_json = importlib.resources.read_text("tests.data", "genes.json")

tests/controllers/test_genes.py: 12 warnings
tests/controllers/test_genesets.py: 11 warnings
tests/controllers/test_publications.py: 5 warnings
tests/controllers/test_species.py: 3 warnings
  /opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/httpx/_client.py:680: DeprecationWarning: The 'app' shortcut is now deprecated. Use the explicit style 'transport=WSGITransport(app=...)' instead.
    warnings.warn(message, DeprecationWarning)

tests/controllers/test_genes.py: 10 warnings
  /opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/httpx/_content.py:202: DeprecationWarning: Use 'content=<...>' to upload raw bytes/text content.
    warnings.warn(message, DeprecationWarning)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

---------- coverage: platform linux, python 3.11.8-final-0 -----------
Name                                            Stmts   Miss  Cover
-------------------------------------------------------------------
src/geneweaver/api/__init__.py                      5      2    60%
src/geneweaver/api/controller/__init__.py           0      0   100%
src/geneweaver/api/controller/api.py               12      0   100%
src/geneweaver/api/controller/genes.py             33      0   100%
src/geneweaver/api/controller/genesets.py          73     14    81%
src/geneweaver/api/controller/message.py            8      0   100%
src/geneweaver/api/controller/publications.py      19      0   100%
src/geneweaver/api/controller/search.py             0      0   100%
src/geneweaver/api/controller/species.py           11      0   100%
src/geneweaver/api/core/__init__.py                 0      0   100%
src/geneweaver/api/core/config.py                   2      0   100%
src/geneweaver/api/core/config_class.py            27      1    96%
src/geneweaver/api/core/exceptions.py              10      1    90%
src/geneweaver/api/core/security.py               118     21    82%
src/geneweaver/api/dependencies.py                 50     26    48%
src/geneweaver/api/main.py                          1      0   100%
src/geneweaver/api/schemas/__init__.py              0      0   100%
src/geneweaver/api/schemas/apimodels.py            18      0   100%
src/geneweaver/api/schemas/auth.py                 19      0   100%
src/geneweaver/api/schemas/messages.py             18     18     0%
src/geneweaver/api/schemas/score.py                13     13     0%
src/geneweaver/api/services/__init__.py             0      0   100%
src/geneweaver/api/services/genes.py               38      3    92%
src/geneweaver/api/services/geneset.py             70     24    66%
src/geneweaver/api/services/io.py                   4      0   100%
src/geneweaver/api/services/parse/__init__.py       0      0   100%
src/geneweaver/api/services/publications.py        17      6    65%
src/geneweaver/api/services/pubmeds.py              0      0   100%
src/geneweaver/api/services/species.py             16      3    81%
-------------------------------------------------------------------
TOTAL                                             582    132    77%
Coverage HTML written to dir htmlcov

Required test coverage of 60% reached. Total coverage: 77.32%
======================= 83 passed, 57 warnings in 2.60s ========================

@francastell francastell had a problem deploying to jax-cluster-dev-10--dev March 15, 2024 14:49 — with GitHub Actions Failure
@francastell francastell temporarily deployed to jax-cluster-dev-10--dev March 18, 2024 20:23 — with GitHub Actions Inactive
bergsalex
bergsalex approved these changes Mar 18, 2024
View reviewed changes
src/geneweaver/api/controller/genes.py
maxiumum=9223372036854775807,
description=api_message.LIMIT,
),
] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to set this to some reasonable value by default. Maybe 1000?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@francastell francastell merged commit aea093a into main Mar 20, 2024
7 checks passed
@bergsalex bergsalex deleted the G3-194-gene-list-endpoint branch May 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergsalex bergsalex bergsalex approved these changes

@gerring gerring gerring approved these changes

@obwalton obwalton Awaiting requested review from obwalton

@rjbluis rjbluis Awaiting requested review from rjbluis

@desais-jax desais-jax Awaiting requested review from desais-jax

@C-1337ka C-1337ka Awaiting requested review from C-1337ka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francastell @gerring @bergsalex