Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Module Helpfiles, Pestertestfiles, and Changelog versioning tool #549

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

kmaranionjc
Copy link
Contributor

Issues

What does this solve?

This tool fixes the issue with the change from CircleCI to GHA migration where we are unable to write back our automations with building module, help and test files, and changelog edits. This process is now done locally with this change.

Is there anything particularly tricky?

N/A

How should this be tested?

  1. Run ."PowerShell/Deploy/Build-Module.ps1" -releasetype major
  • Test out different release type
  1. Validate changelog changes
  • Change current version date to different date
  • Rerun Build-Module
  • Validate that the date is today's date
  1. Validate JumpCloud.psd1 changes (date, version)

@kmaranionjc kmaranionjc self-assigned this Dec 5, 2023
@kmaranionjc kmaranionjc requested a review from a team as a code owner December 5, 2023 21:45
Co-authored-by: Joe Workman <54448601+jworkmanjc@users.noreply.github.com>
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this from another directory and the script threw an error. I think you addressed that in the time before I was able to write the review but yes this does what the card requires. The only other item I want to see here is a mandatory param set for the $releaseType and a validate set to ensure someone who hasn't used this knows what the valid values are.

Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good and is working in my testing!

@kmaranionjc kmaranionjc merged commit a0561c2 into master Dec 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants