Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returnProperties + changelog + version #567

Merged
merged 18 commits into from
Apr 3, 2024

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Mar 22, 2024

Issues

What does this solve?

Updates missing return properties for PS Module and added a test to ensure future changes to the fields property list will be caught in a test

Is there anything particularly tricky?

How should this be tested?

Screenshots

If there are missing properties in one of the functions, the test in this release will catch them and write them out so you can simply copy and paste them:
Screenshot 2024-03-22 at 3 34 26 PM

@jworkmanjc jworkmanjc added PowerShell Module Release for JumpCloud PowerShell Module patch labels Mar 22, 2024
@jworkmanjc jworkmanjc requested a review from a team as a code owner March 22, 2024 21:33
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for losing a few examples in some documentation files

Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work

@gweinjc gweinjc self-requested a review April 2, 2024 21:41
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jworkmanjc jworkmanjc merged commit 8fa2c5a into master Apr 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch PowerShell Module Release for JumpCloud PowerShell Module
Development

Successfully merging this pull request may close these issues.

3 participants