-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
returnProperties + changelog + version #567
Conversation
This reverts commit cdc5cda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for losing a few examples in some documentation files
PowerShell/JumpCloud Module/Public/DirectoryInsights/Get-JCEventCount.ps1
Show resolved
Hide resolved
This reverts commit 55d8a1f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Issues
What does this solve?
Updates missing return properties for PS Module and added a test to ensure future changes to the fields property list will be caught in a test
Is there anything particularly tricky?
How should this be tested?
Screenshots
If there are missing properties in one of the functions, the test in this release will catch them and write them out so you can simply copy and paste them: