RKT-2364: Use upload-secure-artifact action #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcasperson-jc
force-pushed
the
RKT-2364-use-upload-secure-artifact
branch
3 times, most recently
from
df46b93
to
cca4f60
Compare
rcasperson-jc
had a problem deploying
to
PublishToPSGallery
GitHub Actions
Failure
rcasperson-jc
force-pushed
the
RKT-2364-use-upload-secure-artifact
branch
from
cca4f60
to
0445674
Compare
rcasperson-jc
had a problem deploying
to
PublishToPSGallery
GitHub Actions
Failure
rcasperson-jc
force-pushed
the
RKT-2364-use-upload-secure-artifact
branch
from
0445674
to
e66085d
Compare
rcasperson-jc
had a problem deploying
to
PublishToPSGallery
GitHub Actions
Failure
rcasperson-jc
had a problem deploying
to
PublishToPSGallery
GitHub Actions
Failure
rcasperson-jc
had a problem deploying
to
PublishToPSGallery
GitHub Actions
Failure
This reverts commit e66085d.
rcasperson-jc
removed
PowerShell Module
asassujc
approved these changes
Sep 16, 2024
jleibeckjc
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
This simply changes which action we use when uploading artifacts in GHA runs.
actions/uploadcould potentially leak secrets, so this new action scans for secrets before uploading anything.Is there anything particularly tricky?
I did some testing with this by tweaking the actions to actually run the artifact upload parts. Hopefully that didn't mess up any deployments. I'm not sure how those are working.
How should this be tested?
As mentioned, I ran the workflows that upload artifacts and the uploads worked as expected.
Screenshots