feat: faster & standardised object construction #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also created a `BaseObject` object to serve as the root class of all spawnable objects
Horisofine
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
I could kiss you rn. LGTM
Comment on lines
+3
to
+7
| from . import BaseAgent | ||
| from ..controllers import VecJointsController | ||
| from ..sensors import VecContact, VecIMU | ||
| from ..types import Actions, EnvObservations | ||
| from ..universe import Universe |
There was a problem hiding this comment.
Never seen this type of import. wtf is this black magic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to provide an easy to use interface across all the objects in Simulation to make documentation & understanding the system easier and quicker.
As a cool side effect, the project starts up ~40% faster!
Depends on #74