Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for smtp/smtps and optional port #130

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Add support for smtp/smtps and optional port #130

merged 4 commits into from
Jul 19, 2024

Conversation

SanjulaGanepola
Copy link
Collaborator

Fixes #129

@SanjulaGanepola
Add support for smtp/smtps and optional port
70d94c3 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
Merge branch 'main' into feature/email-port-support
446d9dc
@SanjulaGanepola
update docs
e67effe 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
jonnyz32
jonnyz32 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@jonnyz32 jonnyz32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe also add in the example showing how the port parameter can be used

@SanjulaGanepola
add column for optional properties
312d0c0 
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
Copy link
Collaborator Author

Looks good to me. Maybe also add in the example showing how the port parameter can be used

I will add info on that once we add the dedicated email example page. For now, I updated the table to list optional properties

@SanjulaGanepola SanjulaGanepola merged commit 747df3a into main Jul 19, 2024
1 check passed
@SanjulaGanepola SanjulaGanepola deleted the feature/email-port-support branch July 19, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyz32 jonnyz32 jonnyz32 approved these changes

@ThePrez ThePrez ThePrez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for smtp vs smtps
3 participants
@SanjulaGanepola @ThePrez @jonnyz32