Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maker filter, for makers with commas in name are broken #1803

Open
jamieu opened this issue Aug 5, 2024 · 1 comment
Open

Maker filter, for makers with commas in name are broken #1803

jamieu opened this issue Aug 5, 2024 · 1 comment

Comments

@jamieu
Copy link
Member

jamieu commented Aug 5, 2024

https://collection.sciencemuseumgroup.org.uk/search/objects/makers/science-museum,-london

Screenshot 2024-08-05 at 16 13 09
@evancp87 evancp87 self-assigned this Aug 29, 2024
@evancp87
Copy link
Contributor

After extensive research I haven't got to the bottom of the issue. The issue is specifically in the Object tabs, Maker filter, with facets containing commas. The exact same facets work fine in the all tab, and there is almost no apparent difference between the code behind the 'all' and 'object' tabs, other than that the 'all' tab returns results, and the other doesn't for some reason.

There is one reason, however, which could be that the maker value seems to be run through a formatValue function in query-params-objects.js, which uses split-commas.js to split on unescaped commas, whereas it isn't in the all tab code. I'm not sure why this is a problem currently, as commenting out the function doesn't change anything, but is a trail to follow in future.

@evancp87 evancp87 removed their assignment Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants