Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump next from 9.5.5 to 11.1.0 #197

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

sbcatania
Copy link
Contributor

Reasons for making this change

Attempted to fix the typescript version bug but I think this made things worse.

dependabot bot and others added 2 commits August 13, 2021 02:23
Bumps [next](https://github.com/vercel/next.js) from 9.5.5 to 11.1.0.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v9.5.5...v11.1.0)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@sbcatania
Copy link
Contributor Author

Don't merge this because it doesn't work, but @epicfaace I tried to do the typescript upgrade but the build is failing on my end. Can you see if you can check out this PR and find the issue. I don't really go what is going on.

@sbcatania
Copy link
Contributor Author

@epicfaace just following up to see if you can check this out. I'm aware it doesn't work now but wanted to see if you could fix.

@sbcatania sbcatania requested a review from epicfaace August 28, 2021 06:43
@epicfaace epicfaace changed the base branch from dependabot/npm_and_yarn/next-11.1.0 to main August 28, 2021 15:36
@epicfaace
Copy link
Member

Changed the base to main so that CI runs on this branch.

@epicfaace
Copy link
Member

there's also a warning -- "warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json."

removing package-lock.json

@epicfaace
Copy link
Member

I'm not able to run this locally, though, not sure what the issue is

@epicfaace
Copy link
Member

Okay, @sbcatania , here's the process: you'd need to follow the steps in https://nextjs.org/docs/upgrading to properly do the upgrade. I just did step 1 (upgrading React to 17), but it seems like there's already a blank screen issue when running the site locally, so that needs to be debugged.

I'd imagine the entire process might take significant time (maybe 15-20 hours?). Generally, doing major upgrades of something like next js is quite involved and I won't have the bandwidth to do this, though you're welcome to try the steps out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants