-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[strawberryperl] Upgrade issue #13
Comments
Here is an additional message to help reproduce:
choco install strawberryperl --version 5.28.2.1
MsiExec.exe /X{FFFA4206-7CDD-1014-8B25-CEB51AB4960F} /passive /norestart
choco upgrade strawberryperl --version 5.30.0.1 |
Thanks for the investigation. One remark though: when trying to upgrade Strawberry Perl, it still shows as installed on Chocolatey in my tests despite the failure. Anyway, I am not sure what to do here. Is it safe to always uninstall Strawberry Perl before upgrading? Or should we just show a specific error to help users? Any ideas? |
I do know other installers will uninstall previous versions first (VLC, for instance does this). I think putting an uninstall action in It looks like the decision to force uninstall before installing a new version is pretty explicit (see: https://github.com/StrawberryPerl/Perl-Dist-Strawberry/blob/8f666f361456d65bd35fede142318326c5469907/share/msi/MSI_main-v2.wxs.tt Given that when using the Chocolatey package you're expecting Chocolatey to handle thing (and you're not likely mucking about with it) it I'd say it's probably more expected that the package will preform the Uninstall. |
But then what about installed modules or other configuration? I'm afraid users will loose stuff if Chocolatey always uninstalls Strawberry Perl before any upgrades. And it's probably the reason behind the installer current behavior, don't you think? Otherwise, I was thinking about using the zip (or portable) package instead of the msi one. But I'm not sure of the upgrade procedure anyway. Any thoughts? I agree with you that the Chocolatey package should handle upgrades but I just don't want to rush into that Thanks for your help on this because I don't use much Strawberry Perl. |
That's a good point; if someone's using it as their default Perl (I use it as a dependency for This might be something to have handled upstream: https://rt.cpan.org/Public/Dist/Display.html?Name=Perl-Dist-Strawberry |
Aha! They have a mailing list - http://strawberryperl.com/support.html. Perhaps there's a known-good way to handle this. So far this is the what I've found; I'm not sure how relevant it is: https://www.mail-archive.com/win32-vanilla@perl.org/msg00394.html |
From what I understand from https://github.com/StrawberryPerl/Perl-Dist-Strawberry/blob/master/share/msi/MSI_main-v2.wxs.tt, it looks like this is the expected behavior: the setup does not support upgrade, only new install. I'll open an issue there and see if this is something that could be handled by the MSI setup. |
Issue raised on Chocolatey by Tyler Szabo:
The text was updated successfully, but these errors were encountered: