Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscodium.install] Remove unnecessary dependency #56

Closed
vairag22 opened this issue Jun 22, 2023 · 2 comments · Fixed by #58
Closed

[vscodium.install] Remove unnecessary dependency #56

vairag22 opened this issue Jun 22, 2023 · 2 comments · Fixed by #58
Assignees
Labels

Comments

@vairag22
Copy link

Issue: VSCodium has an unnecessary dependency on DotNet4.5.2 package.

Details:

  • Since version 1.78.1, both VSCode and its fork VSCodium do not require DotNet4.5.2.
  • VSCode has already removed the dependency from their package.

Testing: There was no difference when running VSCodium after by forcefully removing DotNot4.5.2 on my machine.

@vairag22
Copy link
Author

vairag22 commented Jun 22, 2023

I believe removing this line from vscodium.install/vscodium.install.nuspec will suffice:
<dependency id="dotnet4.5.2" version="4.5.2.20140902" />

Opened a PR #57. Please review.

@Thilas Thilas self-assigned this Jun 22, 2023
@Thilas Thilas added the bug label Jun 22, 2023
@Thilas
Copy link
Owner

Thilas commented Jun 22, 2023

Thanks for raising this issue. It will be fixed on this other PR (#58) where I'm fixing other similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants