CAN: Initialisation Timeout #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethpotter
force-pushed
the
init-timeout
branch
from
b83fc2a to
50a4bed
Compare
garethpotter
force-pushed
the
init-timeout
branch
from
8709a8b to
39bf2f8
Compare
|
I've now finally had another crack at this, as you will see. I noticed as I was adding a new event that the existing To preserve what looked like the existing behaviour (and what makes sense to me reading it), I now explicitly clear all three of the events, two of which were being implicitly cleared by the call to |
garethpotter
force-pushed
the
init-timeout
branch
2 times, most recently
from
2f3df3f to
68d36f5
Compare
CAN: correct callback CAN: move timer to context
garethpotter
force-pushed
the
init-timeout
branch
from
68d36f5 to
9623764
Compare
martinjaeger
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an (optional) timeout on CAN initialisation.