Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfu: Refactor reboot process using delayed work item #50

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

pasrom
Copy link
Contributor

@pasrom pasrom commented Jun 19, 2024

The response 0x84 might not be sent, because the reboot is initiated already, so make the reboot process delayed with a work item.

Copy link
Contributor

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this improvement!

Just a tiny change request.

src/dfu.c Show resolved Hide resolved
The response 0x84 might not be sent, because the reboot is initiated already,
so make the reboot process delayed with a work item.
@martinjaeger martinjaeger merged commit 0889d3e into ThingSet:main Jun 19, 2024
1 check passed
@pasrom pasrom deleted the fix-dfu-reboot branch June 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants