Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ;mm field reordering #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor ;mm field reordering #735

wants to merge 1 commit into from

Conversation

jiajieh01
Copy link
Contributor

ViBot [X.X.X]

Changelog

Changes

  • Changed the ordering of raidDescriptionFields so that the third column is the empty space instead of the second.

Examples

OLD:
image
NEW:
image

@jiajieh01 jiajieh01 self-assigned this Feb 19, 2024
@jiajieh01 jiajieh01 requested a review from a team as a code owner February 19, 2024 15:57
@jiajieh01 jiajieh01 linked an issue Feb 19, 2024 that may be closed by this pull request
2 tasks
@jiajieh01 jiajieh01 added Lost Halls This relates to the Discord Guild named "Lost Halls" Quality of Life An improvement of something that exists Change A modification to something that exists labels Feb 19, 2024
Copy link
Contributor

@Huntifer-RotMG Huntifer-RotMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a code perspective

@Ragviswa Ragviswa self-requested a review February 21, 2024 22:02
Copy link
Contributor

@Ragviswa Ragviswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keeping merging locked to make sure that this fix works as intended for long afk titles + timestamps

@jiajieh01
Copy link
Contributor Author

Looks like you were correct, the fields do seem to be independently sized. This field switching does not fix the "descripton bleeding onto the next line" problem but it does fix the "gaping hole in the middle of the embed" problem. So I guess that's 1/2 fixed. I'm not really sure how I would actually make it so that, no matter what, the description is always on a single line - might this even be impossible?
image

@Ragviswa
Copy link
Contributor

Looks like you were correct, the fields do seem to be independently sized. This field switching does not fix the "descripton bleeding onto the next line" problem but it does fix the "gaping hole in the middle of the embed" problem. So I guess that's 1/2 fixed. I'm not really sure how I would actually make it so that, no matter what, the description is always on a single line - might this even be impossible? image

The only real way to do so is to have both the Timestamp and Raid Title on the same line. That way, if they do break lines, then at least they will still be grouped together. If you add a bullet point with markdown using -, then I think it will look better as well.

@tro2 tro2 force-pushed the 733-mm-ui-fixing branch 2 times, most recently from 8afa12c to d4923c7 Compare February 28, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change A modification to something that exists Lost Halls This relates to the Discord Guild named "Lost Halls" Quality of Life An improvement of something that exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

;mm UI fixing
3 participants