Updates for version 4.0.1 (#317)

- APP-4055 - [API] Updated v3 gen body to allow 0 and false in body - APP-4056 - [API] Updated Transforms to Support Email Group Type - APP-4057 - [Logging] Added lock to sensitive filter to fix concurrent update exception - APP-4075 - [APP] Added support for System App type - APP-4107 - [Config] Updated config submodule (tcex.json model) to support legacy App Builder Apps - APP-4108 - [API] Removed max_length and min_length from TI models
ThreatConnect-Inc · Aug 31, 2023 · cc2b1dc · cc2b1dc
1 parent 30dc147
commit cc2b1dc
Show file tree

Hide file tree

Showing 27 changed files with 28 additions and 91 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -29,7 +29,7 @@ dependencies = [
   "pydantic<2.0.0",
   "python-dateutil",
   "PyYAML",
-  "redis",
+  "redis<5.0.0",
   "requests",
   "rich",
   "semantic_version",

diff --git a/release_notes.md b/release_notes.md
@@ -3,8 +3,11 @@
 ### 4.0.1
 
 -   APP-4055 - [API] Updated v3 gen body to allow 0 and false in body
--   APP-4056 - [API] Update Transforms to Support Email Group Type
--   APP-4057 - [Logging] Add lock to sensitive filter to fix concurrent update exception
+-   APP-4056 - [API] Updated Transforms to Support Email Group Type
+-   APP-4057 - [Logging] Added lock to sensitive filter to fix concurrent update exception
+-   APP-4075 - [APP] Added support for System App type
+-   APP-4107 - [Config] Updated config submodule (tcex.json model) to support legacy App Builder Apps
+-   APP-4108 - [API] Removed max_length and min_length from TI models
 
 ### 4.0.0
 
@@ -28,7 +31,7 @@
 -   APP-3899 - [CLI] Updated error handling on CLI when downloading template files
 -   APP-3900 - [CLI] Updated proxy support for CLI
 -   APP-3906 - [CLI] Don't create requirements.lock file if any errors occurred during tcex deps.
-    APP-3922 - [API] Update TI Transforms to treat event_date field on some group types as a datetime transform.
+-   APP-3922 - [API] Update TI Transforms to treat event_date field on some group types as a datetime transform.
 
 ### 3.0.7
 

diff --git a/tcex/api/tc/v3/_gen/_gen_model_abc.py b/tcex/api/tc/v3/_gen/_gen_model_abc.py
@@ -358,8 +358,8 @@ def gen_model_fields(self) -> str:
                 _model.append(f'''{self.i2}methods={prop.extra.methods},''')
 
             # max_length
-            if prop.max_length is not None:
-                _model.append(f'''{self.i2}max_length={prop.max_length},''')
+            # if prop.max_length is not None:
+            #     _model.append(f'''{self.i2}max_length={prop.max_length},''')
 
             # max_size
             # if field_max_size is not None:
@@ -370,8 +370,8 @@ def gen_model_fields(self) -> str:
                 _model.append(f'''{self.i2}maximum={prop.max_value},''')
 
             # min_length
-            if prop.min_length is not None:
-                _model.append(f'''{self.i2}min_length={prop.min_length},''')
+            # if prop.min_length is not None:
+            #     _model.append(f'''{self.i2}min_length={prop.min_length},''')
 
             # min_value
             if prop.min_value is not None:

diff --git a/tcex/api/tc/v3/artifacts/artifact_model.py b/tcex/api/tc/v3/artifacts/artifact_model.py
@@ -118,8 +118,6 @@ class ArtifactModel(
         None,
         description='The field name for the artifact.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='fieldName',
     )
@@ -175,17 +173,13 @@ class ArtifactModel(
         None,
         description='The **source** for the Artifact.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='source',
     )
     summary: str | None = Field(
         None,
         description='The **summary** for the Artifact.',
         methods=['POST', 'PUT'],
-        max_length=500,
-        min_length=1,
         read_only=False,
         title='summary',
     )

diff --git a/tcex/api/tc/v3/case_attributes/case_attribute_model.py b/tcex/api/tc/v3/case_attributes/case_attribute_model.py
@@ -104,7 +104,6 @@ class CaseAttributeModel(
         None,
         description='The attribute value.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='value',
     )

diff --git a/tcex/api/tc/v3/cases/case_model.py b/tcex/api/tc/v3/cases/case_model.py
@@ -141,8 +141,6 @@ class CaseModel(
         None,
         description='The description of the Case.',
         methods=['POST', 'PUT'],
-        max_length=1500,
-        min_length=0,
         read_only=False,
         title='description',
     )
@@ -163,8 +161,6 @@ class CaseModel(
         None,
         description='The name of the Case.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='name',
     )
@@ -262,8 +258,6 @@ class CaseModel(
         None,
         description='The **xid** for the Case.',
         methods=['POST'],
-        max_length=100,
-        min_length=10,
         read_only=False,
         title='xid',
     )

diff --git a/tcex/api/tc/v3/group_attributes/group_attribute_model.py b/tcex/api/tc/v3/group_attributes/group_attribute_model.py
@@ -111,7 +111,6 @@ class GroupAttributeModel(
         None,
         description='The attribute value.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='value',
     )

diff --git a/tcex/api/tc/v3/groups/group_model.py b/tcex/api/tc/v3/groups/group_model.py
@@ -81,8 +81,6 @@ class GroupModel(
         applies_to=['Email'],
         description='The email Body.',
         methods=['POST', 'PUT'],
-        max_length=65535,
-        min_length=0,
         read_only=False,
         title='body',
     )
@@ -169,8 +167,6 @@ class GroupModel(
         conditional_required=['Document', 'Report', 'Signature'],
         description='The document or signature file name.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=0,
         read_only=False,
         title='fileName',
     )
@@ -212,8 +208,6 @@ class GroupModel(
         applies_to=['Email'],
         description='The email From field.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='from',
     )
@@ -229,8 +223,6 @@ class GroupModel(
         applies_to=['Email'],
         description='The email Header field.',
         methods=['POST', 'PUT'],
-        max_length=65535,
-        min_length=0,
         read_only=False,
         title='header',
     )
@@ -266,8 +258,6 @@ class GroupModel(
         None,
         description='The name of the group.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='name',
     )
@@ -383,8 +373,6 @@ class GroupModel(
         applies_to=['Email'],
         description='The email Subject section.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=0,
         read_only=False,
         title='subject',
     )
@@ -410,7 +398,6 @@ class GroupModel(
         None,
         description='The **type** for the Group.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='type',
     )

diff --git a/tcex/api/tc/v3/indicator_attributes/indicator_attribute_model.py b/tcex/api/tc/v3/indicator_attributes/indicator_attribute_model.py
@@ -111,7 +111,6 @@ class IndicatorAttributeModel(
         None,
         description='The attribute value.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='value',
     )

diff --git a/tcex/api/tc/v3/indicators/indicator_model.py b/tcex/api/tc/v3/indicators/indicator_model.py
@@ -399,7 +399,6 @@ class IndicatorModel(
         None,
         description='The **type** for the Indicator.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='type',
     )

diff --git a/tcex/api/tc/v3/notes/note_model.py b/tcex/api/tc/v3/notes/note_model.py
@@ -128,8 +128,6 @@ class NoteModel(
         None,
         description='The **text** for the Note.',
         methods=['POST', 'PUT'],
-        max_length=65500,
-        min_length=1,
         read_only=False,
         title='text',
     )

diff --git a/tcex/api/tc/v3/security_labels/security_label_model.py b/tcex/api/tc/v3/security_labels/security_label_model.py
@@ -29,8 +29,6 @@ class SecurityLabelModel(
         None,
         description='Color of the security label.',
         methods=['POST', 'PUT'],
-        max_length=10,
-        min_length=1,
         read_only=False,
         title='color',
     )
@@ -45,8 +43,6 @@ class SecurityLabelModel(
         None,
         description='Description of the security label.',
         methods=['POST', 'PUT'],
-        max_length=400,
-        min_length=1,
         read_only=False,
         title='description',
     )
@@ -60,8 +56,6 @@ class SecurityLabelModel(
         None,
         description='Name of the security label.',
         methods=['POST', 'PUT'],
-        max_length=50,
-        min_length=1,
         read_only=False,
         title='name',
     )

diff --git a/tcex/api/tc/v3/tags/tag_model.py b/tcex/api/tc/v3/tags/tag_model.py
@@ -36,8 +36,6 @@ class TagModel(
         None,
         description='A brief description of the Tag.',
         methods=['POST', 'PUT'],
-        max_length=4000,
-        min_length=0,
         read_only=False,
         title='description',
     )
@@ -72,8 +70,6 @@ class TagModel(
         None,
         description='The **name** for the Tag.',
         methods=['POST', 'PUT'],
-        max_length=128,
-        min_length=1,
         read_only=False,
         title='name',
     )

diff --git a/tcex/api/tc/v3/tasks/task_model.py b/tcex/api/tc/v3/tasks/task_model.py
@@ -94,8 +94,6 @@ class TaskModel(
         None,
         description='The **description** for the Task.',
         methods=['POST', 'PUT'],
-        max_length=1500,
-        min_length=0,
         read_only=False,
         title='description',
     )
@@ -130,8 +128,6 @@ class TaskModel(
         None,
         description='The **name** for the Task.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='name',
     )
@@ -192,8 +188,6 @@ class TaskModel(
         None,
         description='The **xid** for the Task.',
         methods=['POST'],
-        max_length=100,
-        min_length=10,
         read_only=False,
         title='xid',
     )

diff --git a/tcex/api/tc/v3/victim_assets/victim_asset_model.py b/tcex/api/tc/v3/victim_assets/victim_asset_model.py
@@ -28,8 +28,6 @@ class VictimAssetModel(
         conditional_required=['SocialNetwork', 'NetworkAccount'],
         description='The network name.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='accountName',
     )
@@ -39,8 +37,6 @@ class VictimAssetModel(
         conditional_required=['EmailAddress'],
         description='The email address associated with the E-Mail Address asset.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='address',
     )
@@ -80,8 +76,6 @@ class VictimAssetModel(
         conditional_required=['Phone'],
         description='The phone number of the asset.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='phone',
     )
@@ -98,7 +92,6 @@ class VictimAssetModel(
         None,
         description='Type of victim asset.',
         methods=['POST'],
-        min_length=1,
         read_only=False,
         title='type',
     )
@@ -122,8 +115,6 @@ class VictimAssetModel(
         conditional_required=['WebSite'],
         description='The website of the asset.',
         methods=['POST', 'PUT'],
-        max_length=255,
-        min_length=1,
         read_only=False,
         title='website',
     )

diff --git a/tcex/api/tc/v3/victim_attributes/victim_attribute_model.py b/tcex/api/tc/v3/victim_attributes/victim_attribute_model.py
@@ -97,7 +97,6 @@ class VictimAttributeModel(
         None,
         description='The attribute value.',
         methods=['POST', 'PUT'],
-        min_length=1,
         read_only=False,
         title='value',
     )

diff --git a/tcex/api/tc/v3/victims/victim_model.py b/tcex/api/tc/v3/victims/victim_model.py
@@ -57,8 +57,6 @@ class VictimModel(
         None,
         allow_mutation=False,
         description='Description of the Victim.',
-        max_length=255,
-        min_length=0,
         read_only=True,
         title='description',
     )
@@ -72,26 +70,20 @@ class VictimModel(
         None,
         description='Name of the Victim.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=1,
         read_only=False,
         title='name',
     )
     nationality: str | None = Field(
         None,
         description='Nationality of the Victim.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='nationality',
     )
     org: str | None = Field(
         None,
         description='Org of the Victim.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='org',
     )
@@ -116,8 +108,6 @@ class VictimModel(
         None,
         description='Suborg of the Victim.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='suborg',
     )
@@ -142,8 +132,6 @@ class VictimModel(
         None,
         description='Work location of the Victim.',
         methods=['POST', 'PUT'],
-        max_length=100,
-        min_length=0,
         read_only=False,
         title='workLocation',
     )