Add support for track numbering in ID3 TRCK style (NN/MM). #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes TianyiShi2001#5 Example FLAC metadata using this style: comment[0]: album=Chosen Lords comment[1]: discid=820d4b0a comment[2]: title=Reunion 2 comment[3]: artist=Aphex Twin comment[4]: tracknumber=2/10
pinkforest
pushed a commit
that referenced
this pull request
Jul 31, 2022
* Adapt Cargo + License + Changelog * Update GitHub actions to use actions-rs * Fix formatting * Fix clippy * Re-fix formatting * Adapt README.md * Rename crate, update README.md * Fix cargo test * Fix clippy (again) * Docs improvements * Remove deprecated function
pinkforest
added a commit
that referenced
this pull request
Jul 31, 2022
* Upgrade id3 from 0.5.1 to 1.0.3 * Upgrade mp4ameta from 0.6 to 0.11 * Copy test files to tmp directory before running tests * Run GitHub actions on all PR * Import @RodolpheThienard's duration (#4) * give back the duration for mp4 and mp3 * calcul duration for flac * adding set_duration * fix duration for all extension * Remove set_duration + reset test data Co-authored-by: RodolpheThienard <thienard.rodolphe1@gmail.Com> * Import @Dalvany's genre (#5) * Add genre Add genre tag * Add some tests Co-authored-by: Dalvany <9901407+Dalvany@users.noreply.github.com> * Establish fork (#6) * Adapt Cargo + License + Changelog * Update GitHub actions to use actions-rs * Fix formatting * Fix clippy * Re-fix formatting * Adapt README.md * Rename crate, update README.md * Fix cargo test * Fix clippy (again) * Docs improvements * Remove deprecated function * Remove old documentation * 0.3.1 * Re-merged Cargo.toml for 0.4.0 * Re-merged License * Re-merge README.md * Re-merge lib.rs tests * Happy clippy is the best clippy Co-authored-by: Pierre de la Martinière <pierre.de.la.martiniere@gmail.com> Co-authored-by: RodolpheThienard <thienard.rodolphe1@gmail.Com> Co-authored-by: Dalvany <9901407+Dalvany@users.noreply.github.com>
|
We just re-merged audiotags2 into audiotags |
|
@pinkforest This PR is still relevant to the open issue. Can we get this merged? I also added another comment on the linked issue (#5) expanding on why this is a useful change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5
Example FLAC metadata using this style: