Uglify Does Not Work in TW 5.2.0

[kookma]

Uglify a plugin lets to minify the javascripts in TW does not work in TW 5.2.0.

Uglify is very helpful to reduce the size of single TW.html from around 2.364MB to 1.442MB in TW 5.1.23
This is helpful for us when distributing TW through emails and collect students TW for a term paper or course project!

I had some discussion with @flibbles but he was not able to address the issue! See [2]

I would like to know, is it possible to have an option to install compressed or uncompressed core in our wiki like any other plugins?

Ref:

1. https://groups.google.com/g/tiddlywiki/c/kF-OGmkyFfo/m/b272I2rtAwAJ
2. Uglify does not work with Tiddlywiki 5.2 flibbles/tw5-uglify#2

[flibbles]

So for anyone who's interested, the reason Uglify doesn't work in V5.2.0 is because then entire conversion of the tiddler base down to a file to save happens in the new jsonwidget:
https://github.com/Jermolene/TiddlyWiki5/blob/575c2335975cc6cc960d2061ba8fdfa726ed8618/core/modules/widgets/jsontiddler.js#L35-L49
Everything happens here, and there is no way for me to interject the ability to modify the content of a tiddler before it gets written to file. If people are interested in modifying this to allow such a thing to happen, I'd be happy to migrate Uglify.

[pmario]

What, if you change your concept a bit. Let's assume, there is an "uglify edition", Which is empty.html plus the plugin.

• You open the edition
• Drag and drop import the wiki, that should be uglified
• The import mechanism has several new hooks in 5.2.0 - They will allow you to "touch every" tiddler in the different stages of the import procedure
• There is a user facing UI, that will allow the user to decide which elements should be imported.
• Once the code tiddlers are uglified, the default save mechanism will be enough.
• The saver configuration can save the whole thing without the plugin, since it isn't needed anymore.

What do you think?

[pmario]

It's a way to create your own widgets, that are based on core widgets, without the need to monkeypatch the core widget. See: https://github.com/wikilabs/plugins/blob/master/wikilabs/custom-markup/tiddlers/widgets/wl-keyboard.js where I did create a custom-widget.

It has a plugin specific name and only contains the function that has been overwritten .. So it should be easy for you to create your own, modified jsontiddler-widget. Where only a minimum code is changed. ...

[pmario]

also see: https://tiddlywiki.com/dev/#WidgetSubclassingMechanism

[flibbles]

Ah, whoops. Doesn't look like it works for me.
https://github.com/Jermolene/TiddlyWiki5/blob/0be39cfbc2829dbd8637f35110b33c4bd2416dc3/core/modules/widgets/widget.js#L56-L59
If I want to maintain support for V5.1.*, I can't use this, or else my subclass will cause TiddlyWiki to throw an exception.

[pmario]

If I want to maintain support for V5.1.*, I can't use this, or else my subclass will cause TiddlyWiki to throw an exception.

hmmm confused, TW v5.1.x doesn't use this format to store tiddler content. ...

[flibbles]

It doesn't, true. Writes them out using the <$view> widget, and I'll have to keep that either way since that's still how it writes boot.js and boot-prefix.js. However, if uglify is given an old version of tiddlywiki, then even though it won't have the JSONTiddlerWidget, having a subclass of it in my widget will cause an exception.

Although now that I think about it, I can just do something like:

if (Widget.prototype.jsontiddler) {
    exports.baseClass = "jsontiddler";
}

And then my subclass will get ignored if jsontiddler isn't there.

[flibbles]

All right. A new version of Uglify is out, which will work with Tiddlywiki V5.2.0 just as soon as #6057 has been merged.

@kookma, I did this for you, buddy. I'm not sure anyone else out there uses Uglify besides you and me.

[saqimtiaz]

@flibbles thank you. I have two colleagues who wouldn't be using TW at all if it wasn't for Uglify, due to bandwidth constraints.

[kookma]

All right. A new version of Uglify is out, which will work with Tiddlywiki V5.2.0 just as soon as #6057 has been merged.

@kookma, I did this for you, buddy. I'm not sure anyone else out there uses Uglify besides you and me.

Much appreciated @flibbles
Beside the two colleagues of Saq, I have bunch of students all uses the uglify version! None of us know JS ;-)

[kookma]

All right. A new version of Uglify is out, which will work with Tiddlywiki V5.2.0 just as soon as #6057 has been merged.

@flibbles - with regard to the new TW update with #6057 merged, is there any need to have an Uglify update too? It seems the current version does not work!

[flibbles]

Seems to be working for me. Let's take this discussion to flibbles/tw5-uglify#2 since this no longer concerns core TiddlyWiki developers.