Planning bug fix release v5.3.1

[Jermolene]

I am planning to release TiddlyWiki v5.3.1 in order to get the following changes out:

• Fixing [BUG] Export all on tiddlywiki.com 5.3.0 hangs the browser #7592 by merging Fix transclude inefficiency #7647
• Update Change evalSandboxed to use only one context for all modules #4624 not to raise an error when a global assignment is detected and instead just to print a warning by merging Fixed error "Global assignment is not allowed within modules on node" #7648
• Subject to further review, potentially revert implemented destroy() function #7468 to resolve performance regression on removing widgets from the widget tree
• Fixing [BUG] removing tc-tiny-gap-left from the toc-caption element wikitext broke the whole TOC structure visually #7625 by reverting small gap fix for the updated toc macro (alternative to tc-tiny-gap-left) #7219
• Merging fix drag and drop from chrome-like browsers to FireFox #7622

Planned schedule:

• 24th31st July prerelease frozen to further changes, and an announcement posted to the forum
• 7th 18th-21st August release of v5.3.1

[pmario]

@Jermolene .. Please also let us also fix this one: [BUG] Drag and drop from Google Chrome to Firefox fails #7440

[CrossEye]

A minor question: Is the above list everything that would go into the release, or just the important things you're focusing on? Do you cherry pick the commits for this or publish the trunk?

I only ask because I want to know if the following

  |size |The number of rows to display in multiple selection mode |
  |actions |A string containing ActionWidgets to be triggered when the key combination is detected |
  |focus |<<.from-version "5.2.4">> Optional. Set to "yes" to automatically focus the HTML select element after creation |
+ |tabindex |<<.from-version "5.3.1">> Optional. Sets the `tabindex` attribute of the HTML select element to the given value |
  ! Examples

was presumptuous, and whether we will need to go back and change #7594 to update the release version when it actually is deployed.

[pmario]

Usually it's the state of the https://tiddlywiki.com/prerelease/ that will go into a new version. So if something is merged already now, it should be part of the new release.

Except if it interferes with the issues listed in the OP. Code related to the issues may be changed for the new release.

[Jermolene]

Hi @CrossEye thanks @pmario

A minor question: Is the above list everything that would go into the release, or just the important things you're focusing on? Do you cherry pick the commits for this or publish the trunk?

Everything on master will be included in v5.3.1, unless any problems turn up during testing.

[saqimtiaz]

Recommend that we include #7624 which is a bug fix for the missing indentation support for the pragmas introduced in v5.3.0

[Jermolene]

Recommend that we include #7624 which is a bug fix for the missing indentation support for the pragmas introduced in v5.3.0

Thanks @saqimtiaz I've merged that.

[saqimtiaz]

Suggest we revert #7468 due to potential performance considerations.

[flibbles]

I have several plugins that are having trouble with v5.3.0 because they work with the parse tree.

1. They look for macrocalls in the parseTreeNode and can no longer find them (They're transcludes now)
2. They look for transcludes in the parseTreeNode and can no longer parse them (because their "tiddler" attribute has changed to "$tiddler")

I can easily migrate my plugins, but these are backward breaking changes. I don't care if they're rolled back or not, but I would like to know, because it'll change how I migrate my plugins.

[Jermolene]

I can easily migrate my plugins, but these are backward breaking changes. I don't care if they're rolled back or not, but I would like to know, because it'll change how I migrate my plugins.

Hi @flibbles as we've discussed elsewhere, it is very unfortunate that we didn't identify these problems before the release of v5.3.0. I am not planning to revert these changes. I'd prefer to work on better integration between the core and relink, so that things are not so brittle in the future.

[Jermolene]

I've missed a few days with COVID (again!), but recovering well and now getting back up to speed. I've updated the schedule in the OP.

[Jermolene]

We are now entering the prerelease freeze for v5.3.1, where no further PRs will be merged until after the release on August 7th (apart from documentation).

[rmunn]

I just noticed that #7448 has a comment on it about a bug I introduced, which I have pulled out into a GitHub issue at #7678. I have a bugfix PR ready at #7679. I know it's late in the prerelease freeze, but it's a very short bugfix (two lines of code, plus one line fixing a code-style issue in the same file) and should be very easy to test. @Jermolene, would it be possible to get this bugfix reviewed in time to go into 7.3.1?

Edit: Thanks for merging #7679, I'm glad the bugfix will make it into 5.3.1 despite how late I noticed the comment about the bug.

[pmario]

@Jermolene ... You may check the last 2 elements and then close this one. Well done! :)

[flibbles]

This release doesn't seem to break anything of mine. Thanks!

[Jermolene]

Thank you @pmario