Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toc indentation problem #7627

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

pmario
Copy link
Member

@pmario pmario commented Jul 21, 2023

This PR fixes issue: [BUG] removing tc-tiny-gap-left from the toc-caption element wikitext broke the whole TOC structure visually #7625

  • It does revert the CSS definitions from small gap fix for the updated toc macro (alternative to tc-tiny-gap-left) #7219, since they did not apply.
  • It does re-add the tc-tiny-gap-left utility class to the toc-caption macro
  • It adds the change to line 148, requested by Alzacon and was approved by Jeremy
    • It adds a toc-link: no field to the "SecondThreeThree" doc tiddler, so the code in line 148 will be active and can be tested
    • It adds the CSS definition needed for changes in line 148
  • It adds captions to "Third" and "Fourth" tiddler so we can see caption handling

The TOC-macro example tiddler can be used to test all toc code-paths. It should look like this now:

image

  • The tiddlywiki-com table of content indentation works again.
  • Indentation alignment is OK now.

image

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jul 22, 2023 11:37am

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmario please could you remove the modifications to the modified fields? I don't think these changes should cause them to rise to the top of the recent changes list.

@pmario
Copy link
Member Author

pmario commented Jul 22, 2023

@Jermolene .. I did set the modified fields back to the old date

@Jermolene
Copy link
Member

@Jermolene .. I did set the modified fields back to the old date

Thanks @pmario

@Jermolene Jermolene merged commit b000f20 into TiddlyWiki:master Jul 22, 2023
3 checks passed
@pmario pmario deleted the fix-7625-toc-indent-problem branch July 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants