Don't steal focus to the type input field if autofocus is set to "text" #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
yay! |
|
Hello @Jermolene This PR now builds fine |
|
Hi @BurningTreeC I'm concerned that this approach is not backwards compatible. Would it be possible to use a dynamic value for the autofocus attribute in this case? |
|
Hello @Jermolene - what do you mean by dynamic value for the autofocus attribute? |
|
Hi @BurningTreeC it looks like this PR is attempting to apple an additional condition governing the setting of autofocus. I wonder if that can be done in wikitext instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try making this PR happen