Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite tag-picker macros as procedures #7883

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Rewrite tag-picker macros as procedures #7883

merged 2 commits into from
Feb 28, 2024

Commits on Dec 11, 2023

  1. Rewrite tag-picker macros as procedures 

    This PR attempts to modernize the tag-picker macros as procedures, as @Jermolene suggested in [TiddlyWiki#7548 (comment)](TiddlyWiki#7548 (comment)).

What I changed:

* rewrote macros as procedures/replaced text substitutions with variables
* replaced nested $set and $var widgets with $let widgets/functions
* minor rewrites to reduce redundant code
* some additional linebreaks for clarity

*This is functionally identical to my initial PR, [TiddlyWiki#7880](TiddlyWiki#7880, minus the extra file I'd accidentally added. Thank you for bearing with me as I learn to navigate GitHub.
    @etardiff
    etardiff authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b65a093 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from etardiff/etardiff-tag-picker 

    Rewrite tag-picker macros as procedures
    @etardiff
    etardiff authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4ca4089 View commit details
    Browse the repository at this point in the history