-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar-resizer: change $:/themes/...
tiddlers
#8663
base: master
Are you sure you want to change the base?
Sidebar-resizer: change $:/themes/...
tiddlers
#8663
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
sorry for tagging you 😸 The calculations are now done in wikitext in the procedures. |
This works now with all absolute css metrics: Including percentage, which is easy to calculate. The internal calculations are all done in pixel, so this first converts everything to pixel, then calculates, then converts back to the corresponding value. I don't know if this can also support other relative css metrics... |
As I said above, in fixed-fluid mode I'm not settled about how the gap between story-river and sidebar should be handled. |
@BurningTreeC -- I did checkout this branch and did run it, but I can not find any resizer. I think I'm missing something |
Hi @pmario - this should be fixed now |
for the edit-resizer there's one part missing: clamping the values when the tiddler width gets very low |
Cool stuff. I really like it. |
Hi @BurningTreeC I just had a play with the preview, the edit resizer works great. |
https://sidebar-resizer-config.tiddlyhost.com/ I've updated the preview. I decided to go with 0px minwidth for editor and preview |
Thanks @BurningTreeC while you are iterating so fast, do you think it would be worth exploring the pointer capture idea? I think @saqimtiaz has some ideas about the implementation. |
Hi @Jermolene - yes it's surely worth exploring the pointer capture idea. |
@BurningTreeC -- It would be nice, if you would be a bit more specific with your "update" commit messages. With "updates" we (the other devs) are forced to "reverse engineer" the code to see what's going on. That's time consuming. |
Sorry @pmario - I made a little change that made me change more little things at different parts |
Here's the current build: https://sidebar-resizer-config.tiddlyhost.com/ |
But I'm not yet happy with how the storypaddingleft and storypaddingright values work |
…ditional metrics sidebarpadding and previewsliderwidth
This PR uses the same mechanism as #8644 but changes the
$:/themes/tiddlywiki/vanilla/metrics/...
tiddlers directly.Note that in fixed-fluid mode thestory-river
actually changes its width but thetiddlerwidth
remains fixed width as there was no discussion yet how we handle this. I just made the tiddlers adapt to the story-river if the story-river-width goes below the tiddlerwidth.There are some design questions:
I haven't yet added the ControlPanel configurations used for storyminwidth and sidebarminwidth.This PR is just for completeness, I will update it so that we can compare with other possible solutions.
In the meantime this PR has been updated quite a bit, I've put a current build here:
https://sidebar-resizer-config.tiddlyhost.com/